Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2593)

Unified Diff: content/test/gpu/gpu_tests/context_lost.py

Issue 252123003: Work around about:gpucrash tab crashes caused by impl-side painting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/context_lost.py
diff --git a/content/test/gpu/gpu_tests/context_lost.py b/content/test/gpu/gpu_tests/context_lost.py
index f80a78e632f1994eb9ee44c7682e77d62f07e30c..4c014eaac3ea9b51c28d2fecfc8534ee802261f1 100644
--- a/content/test/gpu/gpu_tests/context_lost.py
+++ b/content/test/gpu/gpu_tests/context_lost.py
@@ -72,7 +72,11 @@ class _ContextLostValidator(page_test.PageTest):
new_tab = tab.browser.tabs.New()
# To access these debug URLs from Telemetry, they have to be
# written using the chrome:// scheme.
- new_tab.Navigate('chrome://gpucrash')
+ # The try/except is a workaround for crbug.com/368107.
+ try:
+ new_tab.Navigate('chrome://gpucrash')
+ except (exceptions.TabCrashException, Exception):
+ print 'Tab crashed while navigating to chrome://gpucrash'
# Activate the original tab and wait for completion.
tab.Activate()
completed = False
@@ -82,7 +86,11 @@ class _ContextLostValidator(page_test.PageTest):
completed = True
except util.TimeoutException:
pass
- new_tab.Close()
+ # The try/except is a workaround for crbug.com/368107.
+ try:
+ new_tab.Close()
+ except (exceptions.TabCrashException, Exception):
+ print 'Tab crashed while closing chrome://gpucrash'
if not completed:
raise page_test.Failure(
'Test didn\'t complete (no context lost event?)')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698