Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2521213003: Make Oilpan's Persistent handle work with const types. (Closed)

Created:
4 years, 1 month ago by Bret
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Oilpan's Persistent handle work with const types. R=haraken@chromium.org BUG=668251 Committed: https://crrev.com/99450fb3f41169f64ddefc0175405013dc4424e7 Cr-Commit-Position: refs/heads/master@{#435409}

Patch Set 1 #

Patch Set 2 : add typename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M third_party/WebKit/Source/platform/heap/Persistent.h View 1 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Bret
4 years ago (2016-11-23 20:36:33 UTC) #2
haraken
LGTM
4 years ago (2016-11-24 00:05:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521213003/1
4 years ago (2016-11-24 00:07:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/170093)
4 years ago (2016-11-24 00:24:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521213003/20001
4 years ago (2016-11-29 23:01:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on ...
4 years ago (2016-11-30 01:04:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521213003/20001
4 years ago (2016-11-30 01:14:35 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-30 03:16:22 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521213003/20001
4 years ago (2016-11-30 19:24:59 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 20:47:24 UTC) #21
commit-bot: I haz the power
4 years ago (2016-11-30 20:55:27 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99450fb3f41169f64ddefc0175405013dc4424e7
Cr-Commit-Position: refs/heads/master@{#435409}

Powered by Google App Engine
This is Rietveld 408576698