Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2521193003:
Postmortem dumper: add support for Activity (Closed)
|
Created:
4 years, 1 month ago by manzagop (departed) Modified:
4 years ago Reviewers:
bcwhite CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPostmortem dumper: add support for Activity
BUG=620813
Committed: https://crrev.com/a1722ac90a1459c8b3920305b0ff60e6783dbd57
Cr-Commit-Position: refs/heads/master@{#434230}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Address comments #Patch Set 3 : Clang compile #Messages
Total messages: 16 (8 generated)
manzagop@chromium.org changed reviewers: + bcwhite@chromium.org
Small expansion on the postmortem minidump dumper!
lgtm https://codereview.chromium.org/2521193003/diff/1/components/browser_watcher/... File components/browser_watcher/dump_postmortem_minidump_main_win.cc (right): https://codereview.chromium.org/2521193003/diff/1/components/browser_watcher/... components/browser_watcher/dump_postmortem_minidump_main_win.cc:37: DCHECK_NE(nullptr, out); "DCHECK(out)" is fine just like "if (out)" would be fine. https://codereview.chromium.org/2521193003/diff/1/components/browser_watcher/... components/browser_watcher/dump_postmortem_minidump_main_win.cc:38: for (size_t i = 0; i < indent_level; ++i) { No braces for single-line loops. https://codereview.chromium.org/2521193003/diff/1/components/browser_watcher/... components/browser_watcher/dump_postmortem_minidump_main_win.cc:39: ::fprintf(out, " "); Omit ::, like elsewhere.
Thanks for the review! https://codereview.chromium.org/2521193003/diff/1/components/browser_watcher/... File components/browser_watcher/dump_postmortem_minidump_main_win.cc (right): https://codereview.chromium.org/2521193003/diff/1/components/browser_watcher/... components/browser_watcher/dump_postmortem_minidump_main_win.cc:37: DCHECK_NE(nullptr, out); On 2016/11/23 14:08:56, bcwhite wrote: > "DCHECK(out)" is fine just like "if (out)" would be fine. Done. Here and below. https://codereview.chromium.org/2521193003/diff/1/components/browser_watcher/... components/browser_watcher/dump_postmortem_minidump_main_win.cc:38: for (size_t i = 0; i < indent_level; ++i) { On 2016/11/23 14:08:56, bcwhite wrote: > No braces for single-line loops. Done. https://codereview.chromium.org/2521193003/diff/1/components/browser_watcher/... components/browser_watcher/dump_postmortem_minidump_main_win.cc:39: ::fprintf(out, " "); On 2016/11/23 14:08:56, bcwhite wrote: > Omit ::, like elsewhere. Done.
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bcwhite@chromium.org Link to the patchset: https://codereview.chromium.org/2521193003/#ps20001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
The CQ bit was checked by manzagop@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bcwhite@chromium.org Link to the patchset: https://codereview.chromium.org/2521193003/#ps40001 (title: "Clang compile")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479928481276470,
"parent_rev": "e3669b4f7239895441de2d7eb30e9638c472e11b", "commit_rev":
"fe1f36dfa41e7a77eaa45d65a45d4e68a19d3335"}
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Postmortem dumper: add support for Activity BUG=620813 ========== to ========== Postmortem dumper: add support for Activity BUG=620813 Committed: https://crrev.com/a1722ac90a1459c8b3920305b0ff60e6783dbd57 Cr-Commit-Position: refs/heads/master@{#434230} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a1722ac90a1459c8b3920305b0ff60e6783dbd57 Cr-Commit-Position: refs/heads/master@{#434230} |
