chrome/browser/ui/browser_focus_uitest.cc - Issue 2521153003: Disable BrowserFocusTest.FocusOnNavigate on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_focus_uitest.cc

Issue 2521153003: Disable BrowserFocusTest.FocusOnNavigate on Mac (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_focus_uitest.cc

diff --git a/chrome/browser/ui/browser_focus_uitest.cc b/chrome/browser/ui/browser_focus_uitest.cc

index f249ded0c38ac7aeaf5ad33bc6ce6aced4bcc7cb..c6a81d3424c615c61a5e4deb3b95120295dcf857 100644

--- a/chrome/browser/ui/browser_focus_uitest.cc

+++ b/chrome/browser/ui/browser_focus_uitest.cc

@@ -667,8 +667,8 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, NavigateFromOmniboxIntoNewTab) {

EXPECT_FALSE(IsViewFocused(VIEW_ID_OMNIBOX));

}

-// Flaky on Windows (http://crbug.com/665296).

-#if defined(OS_WIN)

+// Flaky on Windows and Mac (http://crbug.com/665296).

+#if defined(OS_WIN) || defined(OS_MACOSX)

#define MAYBE_FocusOnNavigate DISABLED_FocusOnNavigate

#else

#define MAYBE_FocusOnNavigate FocusOnNavigate

« no previous file with comments | « no previous file | no next file » | no next file with comments »