Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252113002: Web Animations API: Add simple keyframe tests (Closed)

Created:
6 years, 7 months ago by alancutter (OOO until 2018)
Modified:
6 years, 7 months ago
Reviewers:
dstockwell
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Web Animations API: Add simple keyframe tests Add some basic keyframe tests for element.animate(). BUG=367644 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172848

Patch Set 1 #

Patch Set 2 : Fix pluarily #

Patch Set 3 : Renames #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -0 lines) Patch
A LayoutTests/web-animations-api/w3c/resources/keyframes-test.js View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A LayoutTests/web-animations-api/w3c/simple-keyframes.html View 1 2 1 chunk +45 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
alancutter (OOO until 2018)
6 years, 7 months ago (2014-04-29 02:15:40 UTC) #1
dstockwell
lgtm https://codereview.chromium.org/252113002/diff/40001/LayoutTests/web-animations-api/w3c/simple-keyframes.html File LayoutTests/web-animations-api/w3c/simple-keyframes.html (right): https://codereview.chromium.org/252113002/diff/40001/LayoutTests/web-animations-api/w3c/simple-keyframes.html#newcode4 LayoutTests/web-animations-api/w3c/simple-keyframes.html:4: <script src="resources/keyframes-test.js"></script> do we need to put this ...
6 years, 7 months ago (2014-04-29 04:08:22 UTC) #2
alancutter (OOO until 2018)
On 2014/04/29 04:08:22, dstockwell wrote: > lgtm > > https://codereview.chromium.org/252113002/diff/40001/LayoutTests/web-animations-api/w3c/simple-keyframes.html > File LayoutTests/web-animations-api/w3c/simple-keyframes.html (right): > ...
6 years, 7 months ago (2014-04-29 04:55:40 UTC) #3
alancutter (OOO until 2018)
The CQ bit was checked by alancutter@chromium.org
6 years, 7 months ago (2014-04-29 04:55:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/252113002/40001
6 years, 7 months ago (2014-04-29 04:56:04 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 06:00:41 UTC) #6
Message was sent while issue was closed. 
Change committed as 172848

Powered by Google App Engine
This is Rietveld 408576698