Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2521123004: Mus: ws/ should not depend on surfaces/ (Closed)

Created:
4 years, 1 month ago by Fady Samuel
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus: ws/ should not depend on surfaces/ As part of the mus-ws/mus-gpu split, the ws/ directory should not depend on anything in surfaces/. BUG=none Committed: https://crrev.com/66f5a3fc0ebcf1fc89665685444eda4c1855eae2 Cr-Commit-Position: refs/heads/master@{#434095}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -18 lines) Patch
M services/ui/ws/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M services/ui/ws/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/ws/cursor_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/display_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/platform_display_init_params.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/server_window_compositor_frame_sink_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/test_server_window_delegate.h View 2 chunks +6 lines, -2 lines 0 comments Download
M services/ui/ws/test_server_window_delegate.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M services/ui/ws/user_display_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/window_manager_state_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/window_server.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/ws/window_tree_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (13 generated)
Fady Samuel
PTAL sky@
4 years, 1 month ago (2016-11-22 22:57:01 UTC) #5
Fady Samuel
PTAL sky@
4 years, 1 month ago (2016-11-22 22:57:01 UTC) #7
Fady Samuel
PTAL sky@
4 years, 1 month ago (2016-11-22 22:57:02 UTC) #8
sky
LGTM
4 years, 1 month ago (2016-11-22 23:03:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521123004/1
4 years, 1 month ago (2016-11-23 00:41:50 UTC) #13
commit-bot: I haz the power
Failed to apply patch for services/ui/ws/platform_display_init_params.cc: While running git apply --index -p1; error: patch failed: ...
4 years, 1 month ago (2016-11-23 01:16:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521123004/20001
4 years, 1 month ago (2016-11-23 01:33:15 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-23 02:56:43 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/66f5a3fc0ebcf1fc89665685444eda4c1855eae2 Cr-Commit-Position: refs/heads/master@{#434095}
4 years, 1 month ago (2016-11-23 02:59:55 UTC) #22
nhiroki
4 years ago (2016-11-24 03:18:16 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2527003002/ by nhiroki@chromium.org.

The reason for reverting is: Speculative revert for issue 668105. This seems to
be failing WindowServerTest.* and WindowTreeClientTest (mus_ws_unittests) on
Ubuntu-12.04 and Windows-7-SP1..

Powered by Google App Engine
This is Rietveld 408576698