Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2521123003: Continue splitting pageint.h into per-class files (Closed)

Created:
4 years, 1 month ago by Tom Sepez
Modified:
4 years, 1 month ago
Reviewers:
npm, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Continue splitting pageint.h into per-class files Add cpdf_streamparser.h and cpdf_contentparser.h since there are already corresponding .cpp files with the same name. Committed: https://pdfium.googlesource.com/pdfium/+/1aff265f7a210738fc817675c4391f8fe240b81d

Patch Set 1 #

Patch Set 2 : cpdf_contenparser.h #

Patch Set 3 : Remove unused types from pageint.h #

Patch Set 4 : BUILD.gn blunder #

Total comments: 2

Patch Set 5 : const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -110 lines) Patch
M BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M core/fpdfapi/font/cpdf_type3font.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_allstates.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A core/fpdfapi/page/cpdf_contentparser.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
M core/fpdfapi/page/cpdf_contentparser.cpp View 1 2 chunks +3 lines, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_form.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/page/cpdf_page.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/page/cpdf_pageobjectholder.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/page/cpdf_streamcontentparser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A core/fpdfapi/page/cpdf_streamparser.h View 1 2 3 4 1 chunk +60 lines, -0 lines 0 comments Download
M core/fpdfapi/page/cpdf_streamparser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_streamparser_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/pageint.h View 1 2 1 chunk +2 lines, -105 lines 0 comments Download
M testing/libfuzzer/pdf_streamparser_fuzzer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Tom Sepez
npm, dsinclair, ready for review.
4 years, 1 month ago (2016-11-22 17:59:14 UTC) #7
dsinclair
lgtm w/ nit. https://codereview.chromium.org/2521123003/diff/50015/core/fpdfapi/page/cpdf_streamparser.h File core/fpdfapi/page/cpdf_streamparser.h (right): https://codereview.chromium.org/2521123003/diff/50015/core/fpdfapi/page/cpdf_streamparser.h#newcode31 core/fpdfapi/page/cpdf_streamparser.h:31: uint8_t* GetWordBuf() { return m_WordBuffer; } ...
4 years, 1 month ago (2016-11-22 18:13:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521123003/70001
4 years, 1 month ago (2016-11-22 18:36:24 UTC) #11
Tom Sepez
https://codereview.chromium.org/2521123003/diff/50015/core/fpdfapi/page/cpdf_streamparser.h File core/fpdfapi/page/cpdf_streamparser.h (right): https://codereview.chromium.org/2521123003/diff/50015/core/fpdfapi/page/cpdf_streamparser.h#newcode31 core/fpdfapi/page/cpdf_streamparser.h:31: uint8_t* GetWordBuf() { return m_WordBuffer; } On 2016/11/22 18:13:23, ...
4 years, 1 month ago (2016-11-22 18:36:31 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 18:46:05 UTC) #15
Message was sent while issue was closed. 
Committed patchset #5 (id:70001) as
https://pdfium.googlesource.com/pdfium/+/1aff265f7a210738fc817675c4391f8fe240...

Powered by Google App Engine
This is Rietveld 408576698