Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2521113002:
Swarm the tests on the two x64 android testers on chromium.fyi (Closed)
DescriptionSwarm the tests on the two x64 android testers on chromium.fyi
Also missing tests that are on the cq but weren't here.
Needs https://chromium-review.googlesource.com/c/413307/
BUG=664190, 534815
Committed: https://crrev.com/0470f9af87d6dd520c928b9468370c058b2022d1
Cr-Commit-Position: refs/heads/master@{#435830}
Patch Set 1 #Patch Set 2 : add back a number of unittests #Messages
Total messages: 26 (11 generated)
Description was changed from ========== Swarm the tests on the two x64 android testers on chromium.fyi BUG=664190, 534815 ========== to ========== Swarm the testers on the two x64 android testers on chromium.fyi BUG=664190, 534815 ==========
Description was changed from ========== Swarm the testers on the two x64 android testers on chromium.fyi BUG=664190, 534815 ========== to ========== Swarm the tests on the two x64 android testers on chromium.fyi BUG=664190, 534815 ==========
Description was changed from ========== Swarm the tests on the two x64 android testers on chromium.fyi BUG=664190, 534815 ========== to ========== Swarm the tests on the two x64 android testers on chromium.fyi Also give a much more sane set of android tests. (Everything on the cq) BUG=664190, 534815 ==========
Description was changed from ========== Swarm the tests on the two x64 android testers on chromium.fyi Also give a much more sane set of android tests. (Everything on the cq) BUG=664190, 534815 ========== to ========== Swarm the tests on the two x64 android testers on chromium.fyi Also give a much more sane set of android tests. (Everything on the cq) Needs https://chromium-review.googlesource.com/c/413307/ BUG=664190, 534815 ==========
bpastene@chromium.org changed reviewers: + stip@chromium.org
On 2016/11/22 00:25:47, bpastene wrote: Swarming sounds great, but please don't change the set of tests. I think cq probably wants to run more tests thanks it currently is, and I'd like to get an idea which suites are close to passing. (Also, clang and gcc bots should use the same config on x64 except for compilers)
lgtm as long as thakis@ approves of the test changes
On 2016/11/22 05:08:01, Nico wrote: > Swarming sounds great, but please don't change the set of tests. I think cq > probably wants to run more tests thanks it currently is, and I'd like to get an > idea which suites are close to passing. Though I agree it would be nice if the android CQ ran more of these tests, I don't think this is the right place to determine if it could. Let's leave these bots as a staging ground solely for the purposes of testing the devices' unique architecture. For experimenting with new tests, we've traditionally used https://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28trial... (hence the name :P ) That's a much more vanilla android testing bot (it has stable, battle-proven arm devices). Any test flakes/redness won't be muddled with device errors or weird x86 quirks.
On 2016/11/22 19:52:06, bpastene wrote: > On 2016/11/22 05:08:01, Nico wrote: > > Swarming sounds great, but please don't change the set of tests. I think cq > > probably wants to run more tests thanks it currently is, and I'd like to get > an > > idea which suites are close to passing. > > Though I agree it would be nice if the android CQ ran more of these tests, I > don't think this is the right place to determine if it could. Let's leave these > bots as a staging ground solely for the purposes of testing the devices' unique > architecture. > > For experimenting with new tests, we've traditionally used > https://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28trial... > (hence the name :P ) > That's a much more vanilla android testing bot (it has stable, battle-proven arm > devices). Any test flakes/redness won't be muddled with device errors or weird > x86 quirks. Android has historically run too few tests. I've lost several weeks to debugging some issue that angle_unittests would've trivially found (https://bugs.chromium.org/p/chromium/issues/detail?id=487341). When/if I switch compilers on x64, I don't want that to break something that one of the existing test binaries could've told me about. Please don't remove any tests for now.
Any chance to get this in before the long weekend? :-) On Tue, Nov 22, 2016 at 8:25 PM, <thakis@chromium.org> wrote: > On 2016/11/22 19:52:06, bpastene wrote: > > On 2016/11/22 05:08:01, Nico wrote: > > > Swarming sounds great, but please don't change the set of tests. I > think cq > > > probably wants to run more tests thanks it currently is, and I'd like > to get > > an > > > idea which suites are close to passing. > > > > Though I agree it would be nice if the android CQ ran more of these > tests, I > > don't think this is the right place to determine if it could. Let's leave > these > > bots as a staging ground solely for the purposes of testing the devices' > unique > > architecture. > > > > For experimenting with new tests, we've traditionally used > > > https://build.chromium.org/p/chromium.fyi/builders/Android% > 20Tests%20%28trial%29%28dbg%29 > > (hence the name :P ) > > That's a much more vanilla android testing bot (it has stable, > battle-proven > arm > > devices). Any test flakes/redness won't be muddled with device errors or > weird > > x86 quirks. > > Android has historically run too few tests. I've lost several weeks to > debugging > some issue that angle_unittests would've trivially found > (https://bugs.chromium.org/p/chromium/issues/detail?id=487341). When/if I > switch > compilers on x64, I don't want that to break something that one of the > existing > test binaries could've told me about. Please don't remove any tests for > now. > > https://codereview.chromium.org/2521113002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
what's the status here? On Wed, Nov 23, 2016 at 5:47 PM, Nico Weber <thakis@chromium.org> wrote: > Any chance to get this in before the long weekend? :-) > > On Tue, Nov 22, 2016 at 8:25 PM, <thakis@chromium.org> wrote: > >> On 2016/11/22 19:52:06, bpastene wrote: >> > On 2016/11/22 05:08:01, Nico wrote: >> > > Swarming sounds great, but please don't change the set of tests. I >> think cq >> > > probably wants to run more tests thanks it currently is, and I'd like >> to get >> > an >> > > idea which suites are close to passing. >> > >> > Though I agree it would be nice if the android CQ ran more of these >> tests, I >> > don't think this is the right place to determine if it could. Let's >> leave >> these >> > bots as a staging ground solely for the purposes of testing the devices' >> unique >> > architecture. >> > >> > For experimenting with new tests, we've traditionally used >> > >> https://build.chromium.org/p/chromium.fyi/builders/Android%2 >> 0Tests%20%28trial%29%28dbg%29 >> > (hence the name :P ) >> > That's a much more vanilla android testing bot (it has stable, >> battle-proven >> arm >> > devices). Any test flakes/redness won't be muddled with device errors >> or weird >> > x86 quirks. >> >> Android has historically run too few tests. I've lost several weeks to >> debugging >> some issue that angle_unittests would've trivially found >> (https://bugs.chromium.org/p/chromium/issues/detail?id=487341). When/if >> I switch >> compilers on x64, I don't want that to break something that one of the >> existing >> test binaries could've told me about. Please don't remove any tests for >> now. >> >> https://codereview.chromium.org/2521113002/ >> > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Ping. I'm trying to use these bots to do stuff. They've been off for 1.5 weeks now. On Tue, Nov 29, 2016 at 3:24 PM, Nico Weber <thakis@chromium.org> wrote: > what's the status here? > > On Wed, Nov 23, 2016 at 5:47 PM, Nico Weber <thakis@chromium.org> wrote: > >> Any chance to get this in before the long weekend? :-) >> >> On Tue, Nov 22, 2016 at 8:25 PM, <thakis@chromium.org> wrote: >> >>> On 2016/11/22 19:52:06, bpastene wrote: >>> > On 2016/11/22 05:08:01, Nico wrote: >>> > > Swarming sounds great, but please don't change the set of tests. I >>> think cq >>> > > probably wants to run more tests thanks it currently is, and I'd >>> like to get >>> > an >>> > > idea which suites are close to passing. >>> > >>> > Though I agree it would be nice if the android CQ ran more of these >>> tests, I >>> > don't think this is the right place to determine if it could. Let's >>> leave >>> these >>> > bots as a staging ground solely for the purposes of testing the >>> devices' >>> unique >>> > architecture. >>> > >>> > For experimenting with new tests, we've traditionally used >>> > >>> https://build.chromium.org/p/chromium.fyi/builders/Android%2 >>> 0Tests%20%28trial%29%28dbg%29 >>> > (hence the name :P ) >>> > That's a much more vanilla android testing bot (it has stable, >>> battle-proven >>> arm >>> > devices). Any test flakes/redness won't be muddled with device errors >>> or weird >>> > x86 quirks. >>> >>> Android has historically run too few tests. I've lost several weeks to >>> debugging >>> some issue that angle_unittests would've trivially found >>> (https://bugs.chromium.org/p/chromium/issues/detail?id=487341). When/if >>> I switch >>> compilers on x64, I don't want that to break something that one of the >>> existing >>> test binaries could've told me about. Please don't remove any tests for >>> now. >>> >>> https://codereview.chromium.org/2521113002/ >>> >> >> > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Sorry. Was OoO last week, then trooper earlier this week. On 2016/11/23 01:25:52, Nico wrote: > Android has historically run too few tests. I've lost several weeks to debugging > some issue that angle_unittests would've trivially found > (https://bugs.chromium.org/p/chromium/issues/detail?id=487341). When/if I switch > compilers on x64, I don't want that to break something that one of the existing > test binaries could've told me about. Please don't remove any tests for now. I'm not disagreeing with you. I just think these bots aren't the right place to put these tests. But I don't feel too strongly about it, so I added them all back.
Description was changed from ========== Swarm the tests on the two x64 android testers on chromium.fyi Also give a much more sane set of android tests. (Everything on the cq) Needs https://chromium-review.googlesource.com/c/413307/ BUG=664190, 534815 ========== to ========== Swarm the tests on the two x64 android testers on chromium.fyi Also missing tests that are on the cq but weren't here. Needs https://chromium-review.googlesource.com/c/413307/ BUG=664190, 534815 ==========
lgtm, thanks!
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stip@chromium.org Link to the patchset: https://codereview.chromium.org/2521113002/#ps20001 (title: "add back a number of unittests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480642374301190,
"parent_rev": "e06239c2677e2e4792d11f324ab35a8a7156eaf7", "commit_rev":
"d619974bd1538f5958627745fecef8aaf3b62e88"}
Message was sent while issue was closed.
Description was changed from ========== Swarm the tests on the two x64 android testers on chromium.fyi Also missing tests that are on the cq but weren't here. Needs https://chromium-review.googlesource.com/c/413307/ BUG=664190, 534815 ========== to ========== Swarm the tests on the two x64 android testers on chromium.fyi Also missing tests that are on the cq but weren't here. Needs https://chromium-review.googlesource.com/c/413307/ BUG=664190, 534815 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Swarm the tests on the two x64 android testers on chromium.fyi Also missing tests that are on the cq but weren't here. Needs https://chromium-review.googlesource.com/c/413307/ BUG=664190, 534815 ========== to ========== Swarm the tests on the two x64 android testers on chromium.fyi Also missing tests that are on the cq but weren't here. Needs https://chromium-review.googlesource.com/c/413307/ BUG=664190, 534815 Committed: https://crrev.com/0470f9af87d6dd520c928b9468370c058b2022d1 Cr-Commit-Position: refs/heads/master@{#435830} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0470f9af87d6dd520c928b9468370c058b2022d1 Cr-Commit-Position: refs/heads/master@{#435830}
Message was sent while issue was closed.
https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroid%20x64/buil... all tests now fail: On Thu, Dec 1, 2016 at 9:30 PM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Patchset 2 (id:??) landed as > https://crrev.com/0470f9af87d6dd520c928b9468370c058b2022d1 > Cr-Commit-Position: refs/heads/master@{#435830} > > https://codereview.chromium.org/2521113002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Message was sent while issue was closed.
@@@STEP_LOG_LINE@some shards did not complete: 0@It can happen in following cases:@@@ @@@STEP_LOG_LINE@some shards did not complete: 0@ * Test failed to start (missing *.dll/*.so dependency for example)@@@ @@@STEP_LOG_LINE@some shards did not complete: 0@ * Test crashed or hung@@@ @@@STEP_LOG_LINE@some shards did not complete: 0@ * Task expired because there are not enough bots available and are all used@@@ @@@STEP_LOG_LINE@some shards did not complete: 0@ * Swarming service experiences problems@@@ I'm guessing the devices are all offline and swarming doesn't manage to bring them back? On Fri, Dec 2, 2016 at 7:28 PM, Nico Weber <thakis@chromium.org> wrote: > https://build.chromium.org/p/chromium.fyi/builders/ > ClangToTAndroid%20x64/builds/269/steps/blimp_unittests% > 20on%20Android/logs/stdio all tests now fail: > > > On Thu, Dec 1, 2016 at 9:30 PM, commit-bot@chromium.org via > codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> > wrote: > >> Patchset 2 (id:??) landed as >> https://crrev.com/0470f9af87d6dd520c928b9468370c058b2022d1 >> Cr-Commit-Position: refs/heads/master@{#435830} >> >> https://codereview.chromium.org/2521113002/ >> > > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org. |
