[runtime] Fix call-site rendering for inlined calls.

src/runtime/runtime-internal.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/runtime/runtime-utils.h"
 
 #include <memory>
 
 #include "src/arguments.h"
 #include "src/ast/prettyprinter.h"
@@ skipping 348 matching lines @@
   return NULL;
 }
 
 
 namespace {
 
 bool ComputeLocation(Isolate* isolate, MessageLocation* target) {
   JavaScriptFrameIterator it(isolate);
   if (!it.done()) {
     JavaScriptFrame* frame = it.frame();
-    JSFunction* fun = frame->function();
-    Object* script = fun->shared()->script();
+    Object* script = frame->function()->shared()->script();
     if (script->IsScript() &&
         !(Script::cast(script)->source()->IsUndefined(isolate))) {
       Handle<Script> casted_script(Script::cast(script), isolate);
       // Compute the location from the function and the relocation info of the
       // baseline code. For optimized code this will use the deoptimization
       // information to get canonical location information.
       List<FrameSummary> frames(FLAG_max_inlining_levels + 1);
       it.frame()->Summarize(&frames);
       FrameSummary& summary = frames.last();
+      Handle<JSFunction> function = summary.function();
       int pos = summary.abstract_code()->SourcePosition(summary.code_offset());
-      *target = MessageLocation(casted_script, pos, pos + 1, handle(fun));
+      *target = MessageLocation(casted_script, pos, pos + 1, function);

[Toon Verwaest, 2016/11/24 12:37:45]

Mmh, shouldn't it be function->shared()->script() then, in case we have
cross-script inlining? I guess that's not guaranteed to have a script either in
case of manual builtin inlining?

[Michael Starzinger, 2016/11/24 12:53:52]

Done.

       return true;
     }
   }
   return false;
 }
 
 
 Handle<String> RenderCallSite(Isolate* isolate, Handle<Object> object) {
   MessageLocation location;
   if (ComputeLocation(isolate, &location)) {
@@ skipping 142 matching lines @@
 
 RUNTIME_FUNCTION(Runtime_Typeof) {
   HandleScope scope(isolate);
   DCHECK_EQ(1, args.length());
   CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);
   return *Object::TypeOf(isolate, object);
 }
 
 }  // namespace internal
 }  // namespace v8