Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ash/system/chromeos/power/tablet_power_button_controller_unittest.cc

Issue 2521103002: Ignore OnKeyEvent for VKEY_POWER because it is handled by PowerButtonEvent (Closed)
Patch Set: tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
diff --git a/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc b/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
index a6f2b5c0878942d595eef22dc2bf100a79895ea9..a99fb9008e2026badf611f2cd8184761ba56b934 100644
--- a/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
+++ b/ash/system/chromeos/power/tablet_power_button_controller_unittest.cc
@@ -21,6 +21,7 @@
#include "base/test/simple_test_tick_clock.h"
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/dbus/fake_power_manager_client.h"
+#include "ui/events/event.h"
#include "ui/events/test/event_generator.h"
namespace ash {
@@ -299,5 +300,28 @@ TEST_F(TabletPowerButtonControllerTest, ConvertibleOnMaximizeMode) {
generator_->ExitPenPointerMode();
}
+// Tests that a single set of power button pressed-and-released operation should
+// cause only one SetBacklightsForcedOff call.
+TEST_F(TabletPowerButtonControllerTest, IgnorePowerOnKeyEvent) {
+ ui::KeyEvent power_key_pressed(ui::ET_KEY_PRESSED, ui::VKEY_POWER,
+ ui::EF_NONE);
+ ui::KeyEvent power_key_released(ui::ET_KEY_RELEASED, ui::VKEY_POWER,
+ ui::EF_NONE);
+
+ // There are two |power_key_pressed| events and |power_key_released| events
+ // generated for each pressing and releasing, and multiple repeating pressed
+ // events depending on holding.
+ tablet_controller_->OnKeyEvent(&power_key_pressed);
+ tablet_controller_->OnKeyEvent(&power_key_pressed);
+ PressPowerButton();
+ tablet_controller_->OnKeyEvent(&power_key_pressed);
+ tablet_controller_->OnKeyEvent(&power_key_pressed);
+ tablet_controller_->OnKeyEvent(&power_key_pressed);
+ ReleasePowerButton();
+ tablet_controller_->OnKeyEvent(&power_key_released);
+ tablet_controller_->OnKeyEvent(&power_key_released);
+ EXPECT_EQ(1, power_manager_client_->num_set_backlights_forced_off_calls());
+}
+
} // namespace test
} // namespace ash
« no previous file with comments | « ash/system/chromeos/power/tablet_power_button_controller.cc ('k') | chromeos/dbus/fake_power_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698