Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: ash/system/chromeos/power/tablet_power_button_controller.cc

Issue 2521103002: Ignore OnKeyEvent for VKEY_POWER because it is handled by PowerButtonEvent (Closed)
Patch Set: add tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/chromeos/power/tablet_power_button_controller.cc
diff --git a/ash/system/chromeos/power/tablet_power_button_controller.cc b/ash/system/chromeos/power/tablet_power_button_controller.cc
index ece838bb265ef5fa3e0f89e0d112d9ff6016a2ee..de85547f46661cf63f62bae89d1183aebb18bd51 100644
--- a/ash/system/chromeos/power/tablet_power_button_controller.cc
+++ b/ash/system/chromeos/power/tablet_power_button_controller.cc
@@ -138,6 +138,9 @@ void TabletPowerButtonController::SuspendDone(
}
void TabletPowerButtonController::OnKeyEvent(ui::KeyEvent* event) {
+ if (event->key_code() == ui::VKEY_POWER)
Daniel Erat 2016/11/22 00:48:19 please also document why these are ignored. someth
Qiang(Joe) Xu 2016/11/22 01:02:50 Done.
+ return;
+
if (!IsTabletModeActive() && backlights_forced_off_)
SetBacklightsForcedOff(false);
}

Powered by Google App Engine
This is Rietveld 408576698