Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2521073003: Remove the ability in dart2js to turn off syntax-only generic methods. (Closed)

Created:
4 years, 1 month ago by eernst
Modified:
4 years ago
CC:
reviews_dartlang.org, floitsch, Siggi Cherem (dart-lang)
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the ability in dart2js to turn off syntax-only generic methods. This CL removes all the checks for 'enableGenericMethodSyntax' in the implementation, which takes away the ability to turn this feature off and simplifies the code. As a result, `ParserOptions` is now empty; we may want to remove it, but this CL does not do that. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/7809d25b923193ec24ca1561d4958cfa2aa41971

Patch Set 1 #

Patch Set 2 : eernst #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -109 lines) Patch
M pkg/compiler/lib/src/common/resolution.dart View 1 3 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/options.dart View 1 9 chunks +1 line, -25 lines 0 comments Download
M pkg/compiler/lib/src/parser/class_element_parser.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 1 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 14 chunks +13 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser_task.dart View 1 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_parser.dart View 1 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 5 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/tool/perf.dart View 1 4 chunks +2 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/options_helper.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/partial_parser_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
eernst
Remove checks for syntax-only generic methods support, as a clean up action now that the ...
4 years, 1 month ago (2016-11-22 18:23:35 UTC) #2
Siggi Cherem (dart-lang)
Thanks Erik! lgtm! Feel free to delete ParserOptions together with this CL if you like ...
4 years, 1 month ago (2016-11-22 18:49:18 UTC) #4
eernst
Committed patchset #2 (id:20001) manually as 7809d25b923193ec24ca1561d4958cfa2aa41971 (presubmit successful).
4 years ago (2016-11-23 11:16:55 UTC) #6
eernst
Very good! Eliminated `ParserOptions`; now landing.
4 years ago (2016-11-23 11:17:02 UTC) #7
Siggi Cherem (dart-lang)
4 years ago (2016-11-23 14:52:15 UTC) #8
Message was sent while issue was closed.
Thank you so much Erik! :)
lgtm++

Powered by Google App Engine
This is Rietveld 408576698