Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2521043002: Revert of Use switch-case for CSS delimiter parsing (Closed)

Created:
4 years, 1 month ago by piman
Modified:
4 years, 1 month ago
Reviewers:
Timothy Loh, kochi
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use switch-case for CSS delimiter parsing (patchset #2 id:20001 of https://codereview.chromium.org/2515633002/ ) Reason for revert: Suspected cause for fast/forms/relayout-shifts-inner-editor.html failures. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6029 https://bugs.chromium.org/p/chromium/issues/detail?id=667403 Original issue's description: > Use switch-case for CSS delimiter parsing > > This is style-only change and should not change any logic/behavior. > > Committed: https://crrev.com/87c9635abb27e45f913c174043fc115c088aead5 > Cr-Commit-Position: refs/heads/master@{#433470} TBR=timloh@chromium.org,kochi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/749322111601d5aef7f4679bde7652535ccbc391 Cr-Commit-Position: refs/heads/master@{#433599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -46 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +41 lines, -46 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
piman
Created Revert of Use switch-case for CSS delimiter parsing
4 years, 1 month ago (2016-11-21 19:08:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521043002/1
4 years, 1 month ago (2016-11-21 19:09:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 19:10:14 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/749322111601d5aef7f4679bde7652535ccbc391 Cr-Commit-Position: refs/heads/master@{#433599}
4 years, 1 month ago (2016-11-21 19:12:20 UTC) #8
piman
4 years, 1 month ago (2016-11-21 22:28:04 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2519973003/ by piman@chromium.org.

The reason for reverting is: Doesn't look like the revert helped in any way, so
relanding.

Powered by Google App Engine
This is Rietveld 408576698