Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2521033003: Reland: Don't early out recursion into PaintLayerChildren when computing composited bounds. (Closed)

Created:
4 years, 1 month ago by chrishtr
Modified:
4 years ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Don't early out recursion into PaintLayerChildren when computing composited bounds. The difference from last time is that the root ancestorLayer is passed along to PaintLayer::expandRectForStackingChildren, so that localClipRect rects are computed w.r.t the composited element, not the stacking parent. BUG=618046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/53800170ca9baffde6cbb2d9b62d12caf40bfd79 Cr-Commit-Position: refs/heads/master@{#434051}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Messages

Total messages: 19 (14 generated)
chrishtr
This version fixes these bugs: 1. Stacking descendats of a composited PaintLayer which are in ...
4 years ago (2016-11-22 20:43:37 UTC) #12
Xianzhu
lgtm
4 years ago (2016-11-23 00:15:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521033003/60001
4 years ago (2016-11-23 00:22:16 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-23 01:00:00 UTC) #17
commit-bot: I haz the power
4 years ago (2016-11-23 01:01:27 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/53800170ca9baffde6cbb2d9b62d12caf40bfd79
Cr-Commit-Position: refs/heads/master@{#434051}

Powered by Google App Engine
This is Rietveld 408576698