Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2520993005: Do not ignore -t, -u arguments to iossim (Closed)

Created:
4 years ago by smut
Modified:
4 years ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not ignore -t, -u arguments to iossim BUG=663603 R=justincohen@chromium.org TBR=rohitrao

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M testing/iossim/iossim.mm View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
smut
4 years ago (2016-11-23 01:45:35 UTC) #2
justincohen
lgtm
4 years ago (2016-11-23 04:38:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520993005/1
4 years ago (2016-11-23 22:52:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520993005/1
4 years ago (2016-11-24 00:21:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520993005/1
4 years ago (2016-11-24 00:23:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 00:54:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520993005/1
4 years ago (2016-11-24 00:59:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 01:47:54 UTC) #18
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/276217cd97923c96f30654e6f459d23983855603 Cr-Commit-Position: refs/heads/master@{#435110}
4 years ago (2016-11-30 01:29:12 UTC) #20
smut
4 years ago (2016-11-30 01:30:22 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
b89cc7c08feffc293b45c1ff73f2faff43adc8df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698