Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: components/search_engines/template_url.cc

Issue 2520993004: Cleanup: Remove for_search param from search::InstantExtendedEnabledParam() (Closed)
Patch Set: fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/template_url.cc
diff --git a/components/search_engines/template_url.cc b/components/search_engines/template_url.cc
index 1291fbd1ba88f59401269ad60be4f5d8a675ffd8..c6d2515b0aebb72eeb7a7fd3daa8de5a60563216 100644
--- a/components/search_engines/template_url.cc
+++ b/components/search_engines/template_url.cc
@@ -968,10 +968,10 @@ std::string TemplateURLRef::HandleReplacements(
case GOOGLE_INSTANT_EXTENDED_ENABLED:
DCHECK(!i->is_post_param);
HandleReplacement(std::string(),
- search_terms_data.InstantExtendedEnabledParam(
- type_ == SEARCH),
- *i,
- &url);
+ type_ == SEARCH
Peter Kasting 2016/11/22 22:00:44 Nit: Add comment about why we want this to be the
Marc Treib 2016/11/23 10:29:19 Done.
+ ? std::string()
+ : search_terms_data.InstantExtendedEnabledParam(),
+ *i, &url);
break;
case GOOGLE_CONTEXTUAL_SEARCH_VERSION:
« no previous file with comments | « components/search_engines/search_terms_data.cc ('k') | ios/chrome/browser/search_engines/ui_thread_search_terms_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698