Fix a small error in exception handling in convertToBlob

third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/offscreencanvas/OffscreenCanvas.h"
 
 #include "core/dom/ExceptionCode.h"
 #include "core/fileapi/Blob.h"
 #include "core/html/ImageData.h"
 #include "core/html/canvas/CanvasAsyncBlobCreator.h"
@@ skipping 185 matching lines @@
                                      "OffscreenCanvas object is detached.");
     return exceptionState.reject(scriptState);
   }
 
   if (!this->originClean()) {
     exceptionState.throwSecurityError(
         "Tainted OffscreenCanvas may not be exported.");
     return exceptionState.reject(scriptState);
   }
 
+  if (!width() || !height()) {
+    exceptionState.throwDOMException(
+        IndexSizeError, "Zero-sized OffscreenCanvas cannot be transferred.");

[xlai (Olivia), 2016/11/21 16:34:00]

Also, change the error msg. I think it has nothing to do with "transfer".

[xidachen, 2016/11/21 16:40:28]

Done.

+    return exceptionState.reject(scriptState);
+  }
+
   if (!this->isPaintable()) {
     return ScriptPromise();

[xlai (Olivia), 2016/11/21 16:34:00]

Actually, the third case is already handled in this if block
(!this->isPaintable()) but it's just returning an empty promise. Try to throw an
exception here instead of creating a new if block.

[xidachen, 2016/11/21 16:40:28]

Done, makes perfect sense.

   }
 
   double startTime = WTF::monotonicallyIncreasingTime();
   String encodingMimeType = ImageEncoderUtils::toEncodingMimeType(
       options.type(), ImageEncoderUtils::EncodeReasonConvertToBlobPromise);
 
   ImageData* imageData = nullptr;
   if (this->renderingContext()) {
     imageData = this->renderingContext()->toImageData(SnapshotReasonUnknown);
   }
@@ skipping 17 matching lines @@
   return resolver->promise();
 }
 
 DEFINE_TRACE(OffscreenCanvas) {
   visitor->trace(m_context);
   visitor->trace(m_executionContext);
   EventTarget::trace(visitor);
 }
 
 }  // namespace blink