Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2520953004: Avoid calls to WrapUnique in CPDF_streamparser (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid calls to WrapUnique in CPDF_streamparser Committed: https://pdfium.googlesource.com/pdfium/+/12ff1eba3eaa4a27089f1837a0826dfcac163db2

Patch Set 1 #

Total comments: 2

Patch Set 2 : assign unique_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M core/fpdfapi/page/cpdf_streamcontentparser.cpp View 1 5 chunks +6 lines, -10 lines 0 comments Download
M core/fpdfapi/page/cpdf_streamparser.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M core/fpdfapi/page/pageint.h View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Tom Sepez
Lei, ready for review.
4 years ago (2016-11-22 01:13:01 UTC) #5
Tom Sepez
https://codereview.chromium.org/2520953004/diff/1/core/fpdfapi/page/cpdf_streamcontentparser.cpp File core/fpdfapi/page/cpdf_streamcontentparser.cpp (right): https://codereview.chromium.org/2520953004/diff/1/core/fpdfapi/page/cpdf_streamcontentparser.cpp#newcode674 core/fpdfapi/page/cpdf_streamcontentparser.cpp:674: m_pSyntax->ReadInlineStream(m_pDocument, std::move(pDict), pCSObj)); Hmmm. Maybe this needs to return ...
4 years ago (2016-11-22 01:14:50 UTC) #6
Tom Sepez
https://codereview.chromium.org/2520953004/diff/1/core/fpdfapi/page/cpdf_streamcontentparser.cpp File core/fpdfapi/page/cpdf_streamcontentparser.cpp (right): https://codereview.chromium.org/2520953004/diff/1/core/fpdfapi/page/cpdf_streamcontentparser.cpp#newcode674 core/fpdfapi/page/cpdf_streamcontentparser.cpp:674: m_pSyntax->ReadInlineStream(m_pDocument, std::move(pDict), pCSObj)); On 2016/11/22 01:14:49, Tom Sepez wrote: ...
4 years ago (2016-11-22 01:16:37 UTC) #7
Lei Zhang
lgtm
4 years ago (2016-11-22 01:28:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520953004/20001
4 years ago (2016-11-22 01:29:34 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-22 01:47:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/12ff1eba3eaa4a27089f1837a0826dfcac16...

Powered by Google App Engine
This is Rietveld 408576698