Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(165)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/mjsunit/regress/regress-5648.js
Issue
2520883002
:
[parser] Fix scopes in rewriting of for-of and destructuring assignments. (Closed)
Patch Set: Take into account that the scope may have been removed when we get to rewrite.
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/ast/scopes.h
src/ast/scopes.cc
src/parsing/parser.h
src/parsing/parser.cc
src/parsing/pattern-rewriter.cc
test/cctest/interpreter/bytecode_expectations/Generators.golden
test/mjsunit/regress/regress-5648.js
View unified diff
|
Download patch
« src/parsing/pattern-rewriter.cc
('K') |
« test/cctest/interpreter/bytecode_expectations/Generators.golden
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 the V8 project authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
6
var iter = {}
7
iter[Symbol.iterator] = () => ({
8
next: () => ({}),
9
return: () => {throw 666}
10
});
11
12
function* foo() {
13
for (let x of iter) {throw 42}
14
}
15
16
assertThrowsEquals(() => foo().next(), 42);
OLD
NEW
« src/parsing/pattern-rewriter.cc
('K') |
« test/cctest/interpreter/bytecode_expectations/Generators.golden
('k') |
no next file »
|
no next file with comments »
Issue 2520883002: [parser] Fix scopes in rewriting of for-of and destructuring assignments. (Closed)
Created 4 years, 1 month ago by neis
Modified 4 years ago
Reviewers: Dan Ehrenberg, Toon Verwaest
Base URL:
Comments: 13
This is Rietveld
408576698
Chromium Code Reviews
Issue 2520883002:
[parser] Fix scopes in rewriting of for-of and destructuring assignments. (Closed)
