Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2520873003: Count instances managed by each instance template (Closed)

Created:
4 years, 1 month ago by smut
Modified:
4 years ago
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Count instances managed by each instance template BUG=664296 Committed: https://github.com/luci/luci-py/commit/d5d2108ec34c507defdc28af67954f9eafe2e5d4

Patch Set 1 #

Total comments: 5

Patch Set 2 : Replace old metric with new #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -36 lines) Patch
M appengine/gce-backend/instance_group_managers.py View 2 chunks +16 lines, -0 lines 0 comments Download
M appengine/gce-backend/instances.py View 1 1 chunk +0 lines, -20 lines 0 comments Download
M appengine/gce-backend/metrics.py View 1 2 chunks +10 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
smut
With new types of instances coming online (see bug), we should replace the aggregated count ...
4 years, 1 month ago (2016-11-21 22:26:59 UTC) #2
Sergey Berezin (google)
LGTM + comment. https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metrics.py File appengine/gce-backend/metrics.py (right): https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metrics.py#newcode33 appengine/gce-backend/metrics.py:33: 'machine_provider/gce_backend/instances/v2', I'd name it in a ...
4 years, 1 month ago (2016-11-23 02:28:26 UTC) #4
smut
https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metrics.py File appengine/gce-backend/metrics.py (right): https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metrics.py#newcode33 appengine/gce-backend/metrics.py:33: 'machine_provider/gce_backend/instances/v2', On 2016/11/23 02:28:25, Sergey Berezin (google) wrote: > ...
4 years ago (2016-11-23 22:50:57 UTC) #5
Sergey Berezin (google)
https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metrics.py File appengine/gce-backend/metrics.py (right): https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metrics.py#newcode33 appengine/gce-backend/metrics.py:33: 'machine_provider/gce_backend/instances/v2', On 2016/11/23 at 22:50:57, smut wrote: > On ...
4 years ago (2016-11-23 23:42:44 UTC) #6
smut
https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metrics.py File appengine/gce-backend/metrics.py (right): https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metrics.py#newcode33 appengine/gce-backend/metrics.py:33: 'machine_provider/gce_backend/instances/v2', On 2016/11/23 23:42:44, Sergey Berezin (google) wrote: > ...
4 years ago (2016-11-23 23:51:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520873003/20001
4 years ago (2016-11-24 00:18:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/luci-py/commit/d5d2108ec34c507defdc28af67954f9eafe2e5d4
4 years ago (2016-11-24 00:20:57 UTC) #13
Sergey Berezin (google)
4 years ago (2016-11-24 03:51:47 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metri...
File appengine/gce-backend/metrics.py (right):

https://codereview.chromium.org/2520873003/diff/1/appengine/gce-backend/metri...
appengine/gce-backend/metrics.py:33:
'machine_provider/gce_backend/instances/v2',
On 2016/11/23 at 23:51:09, smut wrote:
> No, I don't care about the history. I would prefer this be the only
"instances" metric. Uploaded new patch, and deployed on staging and prod. Should
be safe to delete the old metric's history now and let the new one populate.

Great, I deleted the metric - once the update propagates, we'll hopefully see
just one metric field. Thanks!

Powered by Google App Engine
This is Rietveld 408576698