Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2520873002: [css-ui] Add support for caret-color property (Closed)
Patch Set: Add test results Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
index 5093c1b602851c7ec5f7e801855c0c66266e8fd2..3301dd3a7840fa0936e77923aa6776d69007c1ac 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -1104,12 +1104,26 @@ StyleColor StyleBuilderConverter::convertStyleColor(StyleResolverState& state,
const CSSValue& value,
bool forVisitedLink) {
if (value.isIdentifierValue() &&
- toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor)
+ (toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor))
Timothy Loh 2016/11/30 14:51:10 No reason to add parenthesis here :)
Manuel Rego 2016/11/30 15:41:53 Sure, sorry for the noise again. :-/
return StyleColor::currentColor();
return state.document().textLinkColors().colorFromCSSValue(value, Color(),
forVisitedLink);
}
+StyleAutoColor StyleBuilderConverter::convertStyleAutoColor(
+ StyleResolverState& state,
+ const CSSValue& value,
+ bool forVisitedLink) {
+ if (value.isIdentifierValue()) {
+ if (toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor)
+ return StyleAutoColor::currentColor();
+ if (toCSSIdentifierValue(value).getValueID() == CSSValueAuto)
+ return StyleAutoColor::autoColor();
+ }
+ return state.document().textLinkColors().colorFromCSSValue(value, Color(),
+ forVisitedLink);
+}
+
float StyleBuilderConverter::convertTextStrokeWidth(StyleResolverState& state,
const CSSValue& value) {
if (value.isIdentifierValue() && toCSSIdentifierValue(value).getValueID()) {

Powered by Google App Engine
This is Rietveld 408576698