Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 2520873002: [css-ui] Add support for caret-color property (Closed)
Patch Set: Add new baselines for Mac and Windows Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
index 3bbcc2e917661d6565f3324356e66679f12d6269..d0501eddf726eec1600aad91d725076b399beaa5 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -1103,9 +1103,24 @@ PassRefPtr<SVGDashArray> StyleBuilderConverter::convertStrokeDasharray(
StyleColor StyleBuilderConverter::convertStyleColor(StyleResolverState& state,
const CSSValue& value,
bool forVisitedLink) {
- if (value.isIdentifierValue() &&
- toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor)
- return StyleColor::currentColor();
+ if (value.isIdentifierValue()) {
+ if (toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor)
Timothy Loh 2016/11/28 03:11:21 Not sure why this changed.
Manuel Rego 2016/11/28 10:47:55 This is a leftover from the previous version of th
+ return StyleColor::currentColor();
+ }
+ return state.document().textLinkColors().colorFromCSSValue(value, Color(),
+ forVisitedLink);
+}
+
+StyleAutoColor StyleBuilderConverter::convertStyleAutoColor(
+ StyleResolverState& state,
+ const CSSValue& value,
+ bool forVisitedLink) {
+ if (value.isIdentifierValue()) {
Timothy Loh 2016/11/28 03:11:21 if (value.isIdentifierValue() && toCSSIdentifierVa
Manuel Rego 2016/11/28 10:47:55 Ok.
+ if (toCSSIdentifierValue(value).getValueID() == CSSValueCurrentcolor)
+ return StyleAutoColor::currentColor();
+ if (toCSSIdentifierValue(value).getValueID() == CSSValueAuto)
+ return StyleAutoColor::autoColor();
+ }
return state.document().textLinkColors().colorFromCSSValue(value, Color(),
forVisitedLink);
}

Powered by Google App Engine
This is Rietveld 408576698