[css-ui] Add support for caret-color property

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 1113 matching lines @@
                     other.m_rareInheritedData->visitedLinkTextFillColor() ||
                 m_rareInheritedData->visitedLinkTextStrokeColor() !=
                     other.m_rareInheritedData->visitedLinkTextStrokeColor() ||
                 m_rareInheritedData->visitedLinkTextEmphasisColor() !=
                     other.m_rareInheritedData->visitedLinkTextEmphasisColor() ||
                 m_rareInheritedData->textEmphasisFill !=
                     other.m_rareInheritedData->textEmphasisFill ||
                 m_rareInheritedData->m_textDecorationSkip !=
                     other.m_rareInheritedData->m_textDecorationSkip ||
                 m_rareInheritedData->appliedTextDecorations !=
-                    other.m_rareInheritedData->appliedTextDecorations)) {
+                    other.m_rareInheritedData->appliedTextDecorations ||
+                m_rareInheritedData->caretColor() !=
+                    other.m_rareInheritedData->caretColor() ||
+                m_rareInheritedData->visitedLinkCaretColor() !=
+                    other.m_rareInheritedData->visitedLinkCaretColor())) {
       diff.setTextDecorationOrColorChanged();
     }
   }
 }
 
 void ComputedStyle::addPaintImage(StyleImage* image) {
   if (!m_rareNonInheritedData.access()->m_paintImages) {
     m_rareNonInheritedData.access()->m_paintImages =
         makeUnique<Vector<Persistent<StyleImage>>>();
   }
@@ skipping 923 matching lines @@
       break;
     case CSSPropertyBorderTopColor:
       result = visitedLink ? visitedLinkBorderTopColor() : borderTopColor();
       borderStyle = borderTopStyle();
       break;
     case CSSPropertyBorderBottomColor:
       result =
           visitedLink ? visitedLinkBorderBottomColor() : borderBottomColor();
       borderStyle = borderBottomStyle();
       break;
+    case CSSPropertyCaretColor:
+      result = visitedLink ? visitedLinkCaretColor() : caretColor();
+      if (result.isAutoColor())

[Timothy Loh, 2016/11/22 02:17:35]

Maybe this logic for resolving auto is better in paint code.

[Manuel Rego, 2016/11/22 09:36:01]

If we don't do this here, we need to modify the if after this switch.
But as so far only caret-color accepts "auto" I thought it was better
doing it here.

+        result = StyleColor::currentColor();

[yosin_UTC9, 2016/11/22 02:25:10]

Could you add TODO for improving "auto" color handling? We may want to handle at
least background-color == color case.

[Manuel Rego, 2016/11/22 09:36:01]

Sure that would allow us to pass: caret-color-006.html

+      break;
     case CSSPropertyColor:
       result = visitedLink ? visitedLinkColor() : color();
       break;
     case CSSPropertyOutlineColor:
       result = visitedLink ? visitedLinkOutlineColor() : outlineColor();
       break;
     case CSSPropertyColumnRuleColor:
       result = visitedLink ? visitedLinkColumnRuleColor() : columnRuleColor();
       break;
     case CSSPropertyWebkitTextEmphasisColor:
@@ skipping 20 matching lines @@
       break;
     case CSSPropertyTextDecorationColor:
       result = decorationColorIncludingFallback(visitedLink);
       break;
     default:
       ASSERT_NOT_REACHED();
       break;
   }
 
   if (!result.isCurrentColor())
     return result.getColor();

[Manuel Rego, 2016/11/22 09:36:01]

The call to getColor() will ASSERT if it's "auto".

 
   // FIXME: Treating styled borders with initial color differently causes
   // problems, see crbug.com/316559, crbug.com/276231
   if (!visitedLink &&
       (borderStyle == BorderStyleInset || borderStyle == BorderStyleOutset ||
        borderStyle == BorderStyleRidge || borderStyle == BorderStyleGroove))
     return Color(238, 238, 238);
   return visitedLink ? visitedLinkColor() : color();
 }
 
@@ skipping 317 matching lines @@
     if (value < 0)
       fvalue -= 0.5f;
     else
       fvalue += 0.5f;
   }
 
   return roundForImpreciseConversion<int>(fvalue / zoomFactor);
 }
 
 }  // namespace blink