Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2520853003: [wasm] Add a flag to generate an mjsunit test out of a wasm-code fuzzer test case. (Closed)

Created:
4 years, 1 month ago by ahaas
Modified:
4 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, Michael Hablich, Mircea Trofin
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add a flag to generate an mjsunit test out of a wasm-code fuzzer test case. R=titzer@chromium.org CC=mtrofin@chromium.org Committed: https://crrev.com/480a65738cf05fe6f00099ca2969b82240c01e82 Cr-Commit-Position: refs/heads/master@{#41155}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename wasm-code-generate-test to wasm-code-fuzzer-gen-test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M src/flag-definitions.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/ast-decoder.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M test/fuzzer/wasm-code.cc View 1 4 chunks +44 lines, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
ahaas
4 years, 1 month ago (2016-11-21 15:03:59 UTC) #1
titzer
lgtm https://codereview.chromium.org/2520853003/diff/1/src/flag-definitions.h File src/flag-definitions.h (right): https://codereview.chromium.org/2520853003/diff/1/src/flag-definitions.h#newcode536 src/flag-definitions.h:536: DEFINE_BOOL(wasm_code_generate_test, false, I think we need a better ...
4 years, 1 month ago (2016-11-21 15:11:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520853003/20001
4 years, 1 month ago (2016-11-21 17:58:09 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 18:00:13 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 18:00:37 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/480a65738cf05fe6f00099ca2969b82240c01e82
Cr-Commit-Position: refs/heads/master@{#41155}

Powered by Google App Engine
This is Rietveld 408576698