components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc - Issue 2520853002: [NTP] Cleanup: add brackets in components/ntp_snippets. [2/2]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

Issue 2520853002: [NTP] Cleanup: add brackets in components/ntp_snippets. [2/2] (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/remote/ntp_snippets_status_service.cc ('K') | « components/ntp_snippets/remote/request_throttler.cc ('k') | components/ntp_snippets/sessions/foreign_sessions_suggestions_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

diff --git a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

index d05da3759e6d87e12eafbd789603092ac41eb7d6..5178292330f217f6dfe182ff627df378e52f6724 100644

--- a/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

+++ b/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc

@@ -369,8 +369,9 @@ ForeignSessionsSuggestionsProvider::GetSuggestionCandidates(

std::unique_ptr<sessions::SessionWindow>>& key_value :

session->windows) {

for (const std::unique_ptr<SessionTab>& tab : key_value.second->tabs) {

- if (tab->navigations.empty())

+ if (tab->navigations.empty()) {

continue;

+ }

const SerializedNavigationEntry& navigation = tab->navigations.back();

const std::string id = navigation.virtual_url().spec();