[NTP] Cleanup: add brackets in components/ntp_snippets. [2/2]

components/ntp_snippets/remote/ntp_snippets_status_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/remote/ntp_snippets_status_service.h"
 
 #include <string>
 
 #include "components/ntp_snippets/features.h"
 #include "components/ntp_snippets/pref_names.h"
@@ skipping 16 matching lines @@
     PrefService* pref_service)
     : snippets_status_(SnippetsStatus::EXPLICITLY_DISABLED),
       require_signin_(false),
       signin_manager_(signin_manager),
       pref_service_(pref_service),
       signin_observer_(this) {
   std::string param_value_str = variations::GetVariationParamValueByFeature(
       kArticleSuggestionsFeature, kFetchingRequiresSignin);
   if (param_value_str == kFetchingRequiresSigninEnabled) {
     require_signin_ = true;
-  } else if (!param_value_str.empty() &&

[vitaliii, 2016/11/21 08:50:49]

We have not explicitly considered this case, but my assumption is that we add
brackets here as well. Do you agree?

[Marc Treib, 2016/11/21 09:41:22]

No, "else if" is a very common pattern, and I'd leave that alone. IMO adding the
extra braces doesn't improve readability, and it introduces an extra level of
indentation.

-             param_value_str != kFetchingRequiresSigninDisabled) {
-    DLOG(WARNING) << "Unknow value for the variations parameter "
-                  << kFetchingRequiresSignin << ": " << param_value_str;
+  } else {
+    if (!param_value_str.empty() &&
+        param_value_str != kFetchingRequiresSigninDisabled) {
+      DLOG(WARNING) << "Unknow value for the variations parameter "
+                    << kFetchingRequiresSignin << ": " << param_value_str;
+    }
   }
 }
 
 NTPSnippetsStatusService::~NTPSnippetsStatusService() = default;
 
 // static
 void NTPSnippetsStatusService::RegisterProfilePrefs(
     PrefRegistrySimple* registry) {
   registry->RegisterBooleanPref(prefs::kEnableSnippets, true);
 }
@@ skipping 18 matching lines @@
       base::Bind(&NTPSnippetsStatusService::OnSnippetsEnabledChanged,
                  base::Unretained(this)));
 }
 
 void NTPSnippetsStatusService::OnSnippetsEnabledChanged() {
   OnStateChanged(GetSnippetsStatusFromDeps());
 }
 
 void NTPSnippetsStatusService::OnStateChanged(
     SnippetsStatus new_snippets_status) {
-  if (new_snippets_status == snippets_status_)
+  if (new_snippets_status == snippets_status_) {
     return;
+  }
 
   snippets_status_change_callback_.Run(snippets_status_, new_snippets_status);
   snippets_status_ = new_snippets_status;
 }
 
 bool NTPSnippetsStatusService::IsSignedIn() const {
   return signin_manager_ && signin_manager_->IsAuthenticated();
 }
 
 void NTPSnippetsStatusService::GoogleSigninSucceeded(
@@ skipping 19 matching lines @@
     return SnippetsStatus::SIGNED_OUT_AND_DISABLED;
   }
 
   DVLOG(1) << "[GetNewSnippetsStatus] Enabled, signed "
            << (IsSignedIn() ? "in" : "out");
   return IsSignedIn() ? SnippetsStatus::ENABLED_AND_SIGNED_IN
                       : SnippetsStatus::ENABLED_AND_SIGNED_OUT;
 }
 
 }  // namespace ntp_snippets