Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2520843002: [NTP] Cleanup: add brackets in components/ntp_snippets. [1/2] (Closed)

Created:
4 years, 1 month ago by vitaliii
Modified:
4 years, 1 month ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Cleanup: add brackets in components/ntp_snippets. [1/2] This CL adds curly brackets to |if|, |for| and |while| in components/ntp_snippets. The search was done using "((if)|(for)|(while)) \([^{]*?\n" regexp. Note that it matches multiline statements and this was intended, since there were not many such cases and I wanted to confirm that we did not miss brackets there. BUG=667202 Committed: https://crrev.com/b1a1155c1d237ddcdeba4828c4daccb5db105f72 Cr-Commit-Position: refs/heads/master@{#433505}

Patch Set 1 #

Messages

Total messages: 16 (11 generated)
vitaliii
Hi Marc, could you have a look?
4 years, 1 month ago (2016-11-21 08:23:56 UTC) #5
Marc Treib
lgtm
4 years, 1 month ago (2016-11-21 09:37:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520843002/1
4 years, 1 month ago (2016-11-21 09:38:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 10:50:59 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 10:54:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1a1155c1d237ddcdeba4828c4daccb5db105f72
Cr-Commit-Position: refs/heads/master@{#433505}

Powered by Google App Engine
This is Rietveld 408576698