Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2520833005:
Disable Precompile-platform with clang-cl. (Closed)
|
Created:
4 years, 1 month ago by Nico Modified:
4 years, 1 month ago Reviewers:
Reid Kleckner CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable Precompile-platform with clang-cl.
It currently asserts while trying to build that PCH file.
BUG=667891, 495697
NOTRY=true
Committed: https://crrev.com/5b7b04e7fa59d53b8b7917d4c0cf4081abdfb0e3
Cr-Commit-Position: refs/heads/master@{#434028}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
thakis@chromium.org changed reviewers: + rnk@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Disable Precompile-platform with clang-cl. It currently asserts while trying to build that PCH file. BUG=667891,495697 ========== to ========== Disable Precompile-platform with clang-cl. It currently asserts while trying to build that PCH file. BUG=667891,495697 NOTRY=true ==========
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479857489374030, "parent_rev":
"6635430f174759d7f68baa2e5efaa8659f5307f2", "commit_rev":
"048e97a9647f2b6444111a171271d500e11483d4"}
Message was sent while issue was closed.
Description was changed from ========== Disable Precompile-platform with clang-cl. It currently asserts while trying to build that PCH file. BUG=667891,495697 NOTRY=true ========== to ========== Disable Precompile-platform with clang-cl. It currently asserts while trying to build that PCH file. BUG=667891,495697 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable Precompile-platform with clang-cl. It currently asserts while trying to build that PCH file. BUG=667891,495697 NOTRY=true ========== to ========== Disable Precompile-platform with clang-cl. It currently asserts while trying to build that PCH file. BUG=667891,495697 NOTRY=true Committed: https://crrev.com/5b7b04e7fa59d53b8b7917d4c0cf4081abdfb0e3 Cr-Commit-Position: refs/heads/master@{#434028} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5b7b04e7fa59d53b8b7917d4c0cf4081abdfb0e3 Cr-Commit-Position: refs/heads/master@{#434028}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2526383002/ by thakis@chromium.org. The reason for reverting is: The crash is now hopefully fixed in clang-cl.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
