Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 252083002: Use MSG.time for WebInputEvent timestamps on Windows (Closed)

Created:
6 years, 7 months ago by jdduke (slow)
Modified:
6 years, 7 months ago
Reviewers:
ananta, sadrul, tdresser
CC:
chromium-reviews, jam, jdduke+watch_chromium.org, darin-cc_chromium.org, dgozman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use MSG.time for WebInputEvent timestamps on Windows Previously on Windows, WebInputEvents generated from ui::Events would call |GetMessageTime()| to initialize the WebInputEvent timestamp. There are no guarantees that such a call is valid at that time. Instead, use the MSG.time timestamp generated when the ui::Event was first created from the HWND message. BUG=367156 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267056

Patch Set 1 #

Patch Set 2 : DCHECK? #

Patch Set 3 : Actually pass in the timestamp... #

Total comments: 1

Patch Set 4 : Fix style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -39 lines) Patch
M content/browser/renderer_host/input/web_input_event_builders_win.h View 1 2 3 1 chunk +15 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_win.cc View 1 4 chunks +21 lines, -22 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aura.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aurawin.cc View 1 2 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jdduke (slow)
Does this look about right? I checked each ui::KeyEvent and ui::MouseEvent creation in hwnd_message_handler.cc, so ...
6 years, 7 months ago (2014-04-28 20:45:06 UTC) #1
jdduke (slow)
6 years, 7 months ago (2014-04-28 22:07:44 UTC) #2
tdresser
LGTM https://codereview.chromium.org/252083002/diff/40001/content/browser/renderer_host/input/web_input_event_builders_win.h File content/browser/renderer_host/input/web_input_event_builders_win.h (right): https://codereview.chromium.org/252083002/diff/40001/content/browser/renderer_host/input/web_input_event_builders_win.h#newcode38 content/browser/renderer_host/input/web_input_event_builders_win.h:38: DWORD time_Ms); time_Ms -> time_ms
6 years, 7 months ago (2014-04-29 13:33:36 UTC) #3
jdduke (slow)
sadrul@: OWNER review for web_input_event_aura.cc/web_input_event_aurawin.cc? Thanks.
6 years, 7 months ago (2014-04-29 16:23:09 UTC) #4
sadrul
lgtm
6 years, 7 months ago (2014-04-29 16:24:35 UTC) #5
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-04-29 16:30:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/252083002/60001
6 years, 7 months ago (2014-04-29 16:31:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 18:30:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 18:30:26 UTC) #9
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-04-29 18:40:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/252083002/60001
6 years, 7 months ago (2014-04-29 18:41:38 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 03:06:40 UTC) #12
Message was sent while issue was closed.
Change committed as 267056

Powered by Google App Engine
This is Rietveld 408576698