Don't use isURLAllowed() to determine if a frame element gets a LayoutObject.

Don't use isURLAllowed() to determine if a frame element gets a LayoutObject.

What the style recalc code really wants to do is avoid creating a
LayoutObject if the frame load was blocked. The best way to detect
this is checking if contentFrame() is non-null.

Since this breaks some unit tests that manually bootstrap child
frame creation, this CL also remove the custom bootstrapping code
in favor of using the standard FrameLoaderClient interfaces: this
removes a bunch of code duplication for setting up the FrameView
of a child frame.

BUG=618138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2504573002
Cr-Commit-Position: refs/heads/master@{#433341}
(cherry picked from commit 8a8505dc2c0cd9d4b3e347b7a9ccd9fb3e62491b)

Committed: https://chromium.googlesource.com/chromium/src/+/4e0c05dd02715b177c56fcf85654bb28b246ecda

[dcheng, 2016-11-21 22:34:05]

Description was changed from

==========
Don't use isURLAllowed() to determine if a frame element gets a LayoutObject.

What the style recalc code really wants to do is avoid creating a
LayoutObject if the frame load was blocked. The best way to detect
this is checking if contentFrame() is non-null.

Since this breaks some unit tests that manually bootstrap child
frame creation, this CL also remove the custom bootstrapping code
in favor of using the standard FrameLoaderClient interfaces: this
removes a bunch of code duplication for setting up the FrameView
of a child frame.

BUG=618138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2504573002
Cr-Commit-Position: refs/heads/master@{#433341}
(cherry picked from commit 8a8505dc2c0cd9d4b3e347b7a9ccd9fb3e62491b)
==========

to

==========
Don't use isURLAllowed() to determine if a frame element gets a LayoutObject.

What the style recalc code really wants to do is avoid creating a
LayoutObject if the frame load was blocked. The best way to detect
this is checking if contentFrame() is non-null.

Since this breaks some unit tests that manually bootstrap child
frame creation, this CL also remove the custom bootstrapping code
in favor of using the standard FrameLoaderClient interfaces: this
removes a bunch of code duplication for setting up the FrameView
of a child frame.

BUG=618138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2504573002
Cr-Commit-Position: refs/heads/master@{#433341}
(cherry picked from commit 8a8505dc2c0cd9d4b3e347b7a9ccd9fb3e62491b)

Committed:
https://chromium.googlesource.com/chromium/src/+/4e0c05dd02715b177c56fcf85654...
==========

[dcheng, 2016-11-21 22:34:08]

Committed patchset #1 (id:1) manually as
4e0c05dd02715b177c56fcf85654bb28b246ecda.