Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2520793002: [ash-md] Allows ToggleButton to have a border and adds focus rectangle (Closed)

Created:
4 years, 1 month ago by varkha
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[ash-md] Allows ToggleButton to have a border and adds focus rectangle - Allows ToggleButton to accept a border set externally. - Allows ToggleButton to have a tooltip that includes ThumbView. - Adds TrayPopupUtils::CreateToggleButton to set up ToggleButtons for use in system menu. - Uses TrayPopupUtils::CreateToggleButton in IME, Bluetooth and Network pages. BUG=652492 TEST=manual Bring focus using Tab to a toggle button in Network detailed page. (focus rectangle appears). Press Space (toggle switches) Press Enter (toggle switches) Tab (focus switches to the next row). Review-Url: https://codereview.chromium.org/2506133003 Cr-Commit-Position: refs/heads/master@{#433386} (cherry picked from commit 9bd7f8c886e2b6131646b78d7598d2115894b385) Committed: https://chromium.googlesource.com/chromium/src/+/7061f7f5af36c3d2647f7179a4567493a97648d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -47 lines) Patch
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_list_view.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ash/common/system/chromeos/network/network_list_md.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M ash/common/system/tray/tray_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_constants.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 3 chunks +21 lines, -0 lines 0 comments Download
M ui/views/controls/button/toggle_button.h View 4 chunks +18 lines, -4 lines 0 comments Download
M ui/views/controls/button/toggle_button.cc View 9 chunks +52 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
varkha
4 years, 1 month ago (2016-11-21 03:38:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7061f7f5af36c3d2647f7179a4567493a97648d0.

Powered by Google App Engine
This is Rietveld 408576698