Pull up tests for WebP and GIF image decoders.

Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition
checks if the baseline hashes are equivalent to the incremental hashes.

Committed: https://crrev.com/40ce4579e49be92da9fc1569e25f539e44480c97
Cr-Commit-Position: refs/heads/master@{#434828}

[joostouwerling, 2016-11-20 18:59:08]

Description was changed from

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which were shared by
both GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest such that it can be
used by APNG tests.
==========

to

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.
==========

[joostouwerling, 2016-11-20 19:40:20]

Description was changed from

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.
==========

to

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition checks
if the baseline hashes are equivalent to the incremental hashes.
==========

[joostouwerling, 2016-11-20 19:40:39]

Description was changed from

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition checks
if the baseline hashes are equivalent to the incremental hashes.
==========

to

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition
checks if the baseline hashes are equivalent to the incremental hashes.
==========

[joostouwerling, 2016-11-20 20:00:31]

joostouwerling@google.com changed reviewers:
+ scroggo@chromium.org, urvang@chromium.org

[urvang, 2016-11-21 20:16:15]

lgtm

https://codereview.chromium.org/2520753002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp
(right):

https://codereview.chromium.org/2520753002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp:401:
DISABLED_resumePartialDecodeAfterClearFrameBufferCache) {
Unrelated to this patch, but can you later check if this test is still timing
out? Thanks!

[scroggo_chromium, 2016-11-28 16:10:30]

lgtm

[joostouwerling, 2016-11-29 00:34:10]

The CQ bit was checked by joostouwerling@google.com

[commit-bot: I haz the power, 2016-11-29 00:35:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:04:10]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480379650415510,
"parent_rev": "ffc93582e5095785d618628d6e7b563c3db236fd", "commit_rev":
"5595780114bfa80be106e51cbf47e27bf888fcae"}

[commit-bot: I haz the power, 2016-11-29 02:05:44]

Description was changed from

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition
checks if the baseline hashes are equivalent to the incremental hashes.
==========

to

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition
checks if the baseline hashes are equivalent to the incremental hashes.
==========

[commit-bot: I haz the power, 2016-11-29 02:05:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-29 02:08:20]

Description was changed from

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition
checks if the baseline hashes are equivalent to the incremental hashes.
==========

to

==========
Pull up tests for WebP and GIF image decoders.

Just a refactor. No change in behavior, no new tests.

Pull up updateRequiredPreviousFrameAfterFirstDecode,
resumePartialDecodingAfterClearFrameBufferCache, which are shared by
GIFImagerDecoderTest and WEBPImageDecoderTest.

Pull up testAlphaBlending from WEBPImageDecoderTest, so that it can be
reused in APNG tests.

Use ImageDecoderTestHelpers::testByteByByteDecode for GIF's
parseAndDecodeByteByByte test. This tests for the same, and in addition
checks if the baseline hashes are equivalent to the incremental hashes.

Committed: https://crrev.com/40ce4579e49be92da9fc1569e25f539e44480c97
Cr-Commit-Position: refs/heads/master@{#434828}
==========

[commit-bot: I haz the power, 2016-11-29 02:08:20]

Patchset 3 (id:??) landed as
https://crrev.com/40ce4579e49be92da9fc1569e25f539e44480c97
Cr-Commit-Position: refs/heads/master@{#434828}