Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 252073002: Create a dummy sandbox_unittests target on Mac. (Closed)

Created:
6 years, 7 months ago by Robert Sesek
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Create a dummy sandbox_mac_unittests target. This will allow the test suite to be added to buildbot before any real code lands, so it can be properly tested. BUG=367863 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266740

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Rename target to sandbox_mac_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A sandbox/mac/sandbox_mac.gypi View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A sandbox/mac/temp_test.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M sandbox/sandbox.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Robert Sesek
6 years, 7 months ago (2014-04-28 19:47:11 UTC) #1
jln (very slow on Chromium)
lgtm https://codereview.chromium.org/252073002/diff/20001/sandbox/mac/sandbox_mac.gypi File sandbox/mac/sandbox_mac.gypi (right): https://codereview.chromium.org/252073002/diff/20001/sandbox/mac/sandbox_mac.gypi#newcode8 sandbox/mac/sandbox_mac.gypi:8: 'target_name': 'sandbox_unittests', When I added sandbox_linux_unittests it was ...
6 years, 7 months ago (2014-04-28 19:53:37 UTC) #2
Robert Sesek
On 2014/04/28 19:53:37, jln wrote: > lgtm > > https://codereview.chromium.org/252073002/diff/20001/sandbox/mac/sandbox_mac.gypi > File sandbox/mac/sandbox_mac.gypi (right): > ...
6 years, 7 months ago (2014-04-28 20:15:07 UTC) #3
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 7 months ago (2014-04-28 20:15:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/252073002/40001
6 years, 7 months ago (2014-04-28 20:16:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 21:22:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_aosp
6 years, 7 months ago (2014-04-28 21:22:13 UTC) #7
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 7 months ago (2014-04-28 21:26:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/252073002/40001
6 years, 7 months ago (2014-04-28 21:27:42 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 02:30:14 UTC) #10
Message was sent while issue was closed.
Change committed as 266740

Powered by Google App Engine
This is Rietveld 408576698