Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: gni/v8.gni

Issue 2520683002: Properly define v8_enable_inspector and its override in GN. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gni/isolate.gni ('k') | test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("//build/config/v8_target_cpu.gni") 6 import("//build/config/v8_target_cpu.gni")
7 import("//build_overrides/v8.gni")
7 8
8 declare_args() { 9 declare_args() {
9 # Indicate if valgrind was fetched as a custom deps to make it available on 10 # Indicate if valgrind was fetched as a custom deps to make it available on
10 # swarming. 11 # swarming.
11 v8_has_valgrind = false 12 v8_has_valgrind = false
12 13
13 # Indicate if gcmole was fetched as a hook to make it available on swarming. 14 # Indicate if gcmole was fetched as a hook to make it available on swarming.
14 v8_gcmole = false 15 v8_gcmole = false
15 16
16 # Turns on compiler optimizations in V8 in Debug build. 17 # Turns on compiler optimizations in V8 in Debug build.
17 v8_optimized_debug = true 18 v8_optimized_debug = true
18 19
19 # Support for backtrace_symbols on linux. 20 # Support for backtrace_symbols on linux.
20 v8_enable_backtrace = "" 21 v8_enable_backtrace = ""
21 22
22 # Enable the snapshot feature, for fast context creation. 23 # Enable the snapshot feature, for fast context creation.
23 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html 24 # http://v8project.blogspot.com/2015/09/custom-startup-snapshots.html
24 v8_use_snapshot = true 25 v8_use_snapshot = true
25 26
26 # Use external files for startup data blobs: 27 # Use external files for startup data blobs:
27 # the JS builtins sources and the start snapshot. 28 # the JS builtins sources and the start snapshot.
28 v8_use_external_startup_data = "" 29 v8_use_external_startup_data = ""
29 30
30 # Enable ECMAScript Internationalization API. Enabling this feature will 31 # Enable ECMAScript Internationalization API. Enabling this feature will
31 # add a dependency on the ICU library. 32 # add a dependency on the ICU library.
32 v8_enable_i18n_support = true 33 v8_enable_i18n_support = true
34
35 # Enable inspector. See include/v8-inspector.h.
36 v8_enable_inspector = v8_enable_inspector_override
33 } 37 }
34 38
35 if (v8_use_external_startup_data == "") { 39 if (v8_use_external_startup_data == "") {
36 # If not specified as a gn arg, use external startup data by default if 40 # If not specified as a gn arg, use external startup data by default if
37 # a snapshot is used and if we're not on ios. 41 # a snapshot is used and if we're not on ios.
38 v8_use_external_startup_data = v8_use_snapshot && !is_ios 42 v8_use_external_startup_data = v8_use_snapshot && !is_ios
39 } 43 }
40 44
41 if (v8_enable_backtrace == "") { 45 if (v8_enable_backtrace == "") {
42 v8_enable_backtrace = is_debug && !v8_optimized_debug 46 v8_enable_backtrace = is_debug && !v8_optimized_debug
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 } 117 }
114 118
115 template("v8_component") { 119 template("v8_component") {
116 component(target_name) { 120 component(target_name) {
117 forward_variables_from(invoker, "*", [ "configs" ]) 121 forward_variables_from(invoker, "*", [ "configs" ])
118 configs += invoker.configs 122 configs += invoker.configs
119 configs -= v8_remove_configs 123 configs -= v8_remove_configs
120 configs += v8_add_configs 124 configs += v8_add_configs
121 } 125 }
122 } 126 }
OLDNEW
« no previous file with comments | « gni/isolate.gni ('k') | test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698