Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: gni/isolate.gni

Issue 2520683002: Properly define v8_enable_inspector and its override in GN. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build_overrides/v8.gni ('k') | gni/v8.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 the V8 project authors. All rights reserved. 1 # Copyright 2016 the V8 project authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sanitizers/sanitizers.gni") 5 import("//build/config/sanitizers/sanitizers.gni")
6 import("//build_overrides/v8.gni")
7 import("//third_party/icu/config.gni") 6 import("//third_party/icu/config.gni")
8 import("v8.gni") 7 import("v8.gni")
9 8
10 declare_args() { 9 declare_args() {
11 # Sets the test isolation mode (noop|prepare|check). 10 # Sets the test isolation mode (noop|prepare|check).
12 v8_test_isolation_mode = "noop" 11 v8_test_isolation_mode = "noop"
13 } 12 }
14 13
15 template("v8_isolate_run") { 14 template("v8_isolate_run") {
16 forward_variables_from(invoker, 15 forward_variables_from(invoker,
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 if (is_component_build) { 89 if (is_component_build) {
91 component = "shared_library" 90 component = "shared_library"
92 } else { 91 } else {
93 component = "static_library" 92 component = "static_library"
94 } 93 }
95 if (icu_use_data_file) { 94 if (icu_use_data_file) {
96 icu_use_data_file_flag = "1" 95 icu_use_data_file_flag = "1"
97 } else { 96 } else {
98 icu_use_data_file_flag = "0" 97 icu_use_data_file_flag = "0"
99 } 98 }
100 if (v8_enable_inspector_override) { 99 if (v8_enable_inspector) {
101 enable_inspector = "1" 100 enable_inspector = "1"
102 } else { 101 } else {
103 enable_inspector = "0" 102 enable_inspector = "0"
104 } 103 }
105 if (v8_use_external_startup_data) { 104 if (v8_use_external_startup_data) {
106 use_external_startup_data = "1" 105 use_external_startup_data = "1"
107 } else { 106 } else {
108 use_external_startup_data = "0" 107 use_external_startup_data = "0"
109 } 108 }
110 if (v8_use_snapshot) { 109 if (v8_use_snapshot) {
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 ] 184 ]
186 } else { 185 } else {
187 args += [ 186 args += [
188 "--config-variable", 187 "--config-variable",
189 "msvs_version=0", 188 "msvs_version=0",
190 ] 189 ]
191 } 190 }
192 } 191 }
193 } 192 }
194 } 193 }
OLDNEW
« no previous file with comments | « build_overrides/v8.gni ('k') | gni/v8.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698