Issue 252063003: disable Object.observe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252063003: disable Object.observe (Closed)

Created:
6 years, 7 months ago by rafaelw

Modified:
6 years, 7 months ago

Reviewers:
danno, adamk, rossberg, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

disable Object.observe R=danno@chromium.org, danno BUG= Committed: https://code.google.com/p/v8/source/detail?r=21062

Patch Set 3 : ws #

Total comments: 3

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -1 line)			Patch
M	src/object-observe.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/cctest.status	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 2	1 chunk	+8 lines, -0 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rafaelw

Disable M35 by not exposing API on Object. Note that this patch disables non-Object.observe tests ...

6 years, 7 months ago (2014-04-28 22:49:07 UTC) #1

rossberg

https://codereview.chromium.org/252063003/diff/40001/test/mjsunit/mjsunit.status File test/mjsunit/mjsunit.status (right): https://codereview.chromium.org/252063003/diff/40001/test/mjsunit/mjsunit.status#newcode132 test/mjsunit/mjsunit.status:132: 'array-push7': [SKIP], While you're at it, can you please ...

6 years, 7 months ago (2014-04-29 11:03:56 UTC) #3

danno

6 years, 7 months ago (2014-04-29 15:12:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r21062 (tree was closed).

Expand Messages | Collapse Messages

Issue 252063003: disable Object.observe (Closed)

Description

Patch Set 1 #

Patch Set 2 : disable tests #

Patch Set 3 : ws #

Messages