Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2520623005: X87:[test] Disables 2 test cases for x87. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87:[test] Disables 2 test cases for x87. The reason: The CL #40862 (https://codereview.chromium.org/2433093002 ) caused 2 test cases failed for X87. Because Both 2 test cases (MoveOptimizerTest.RemovesRedundantExplicit and RegisterAllocatorTest.CanAllocateFPRegisters) needs 2 allocatable Float/Double registers. But there's only 1 allocatable Float/Double register in x87 turbofan compiler, i.e.: register index 0. This CL disables MoveOptimizerTest.RemovesRedundantExplicit and RegisterAllocatorTest.CanAllocateFPRegisters test cases for x87. BUG= Committed: https://crrev.com/b94b53a28c61326f494089382e3cf993c186c122 Cr-Commit-Position: refs/heads/master@{#41131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/unittests/unittests.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-21 07:00:17 UTC) #2
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-21 07:01:09 UTC) #4
titzer
On 2016/11/21 07:01:09, zhengxing.li wrote: > PTAL, thanks! lgtm
4 years, 1 month ago (2016-11-21 10:08:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520623005/1
4 years, 1 month ago (2016-11-21 10:26:02 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 10:50:05 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 10:50:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b94b53a28c61326f494089382e3cf993c186c122
Cr-Commit-Position: refs/heads/master@{#41131}

Powered by Google App Engine
This is Rietveld 408576698