Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 25206002: A height of a table which has position: absolute and box-sizing: border-box ignores half of the bor… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: /Users/yukisekiguchi/work/chromium-blink/src/third_party/WebKit/LayoutTests/fast/box-sizing/table-c… Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/box-sizing/table-no-collapse-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBox.cpp
diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp
index b0cd4d79b14e72a0f184c0a89d600c638d763fe2..9065806479985f1f80bb518854c36db7b53f3472 100644
--- a/Source/core/rendering/RenderBox.cpp
+++ b/Source/core/rendering/RenderBox.cpp
@@ -3663,18 +3663,18 @@ void RenderBox::computePositionedLogicalHeightUsing(Length logicalHeightLength,
bool logicalBottomIsAuto = logicalBottom.isAuto();
RenderView* renderView = view();
+ LayoutUnit resolvedLogicalHeight;
// Height is never unsolved for tables.
if (isTable()) {
- logicalHeightLength.setValue(Fixed, contentLogicalHeight);
+ resolvedLogicalHeight = contentLogicalHeight;
logicalHeightIsAuto = false;
+ } else {
+ if (logicalHeightLength.isIntrinsic())
+ resolvedLogicalHeight = computeIntrinsicLogicalContentHeightUsing(logicalHeightLength, contentLogicalHeight, bordersPlusPadding);
+ else
+ resolvedLogicalHeight = adjustContentBoxLogicalHeightForBoxSizing(valueForLength(logicalHeightLength, containerLogicalHeight, renderView));
}
- LayoutUnit resolvedLogicalHeight;
- if (logicalHeightLength.isIntrinsic())
- resolvedLogicalHeight = computeIntrinsicLogicalContentHeightUsing(logicalHeightLength, contentLogicalHeight, bordersPlusPadding);
- else
- resolvedLogicalHeight = adjustContentBoxLogicalHeightForBoxSizing(valueForLength(logicalHeightLength, containerLogicalHeight, renderView));
-
if (!logicalTopIsAuto && !logicalHeightIsAuto && !logicalBottomIsAuto) {
/*-----------------------------------------------------------------------*\
* If none of the three are 'auto': If both 'margin-top' and 'margin-
« no previous file with comments | « LayoutTests/fast/box-sizing/table-no-collapse-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698