Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/core/rendering/RenderBox.cpp

Issue 25206002: A height of a table which has position: absolute and box-sizing: border-box ignores half of the bor… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 7 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 3647 matching lines...) Expand 10 before | Expand all | Expand 10 after
3658 3658
3659 LayoutUnit logicalTopValue = 0; 3659 LayoutUnit logicalTopValue = 0;
3660 3660
3661 bool logicalHeightIsAuto = logicalHeightLength.isAuto(); 3661 bool logicalHeightIsAuto = logicalHeightLength.isAuto();
3662 bool logicalTopIsAuto = logicalTop.isAuto(); 3662 bool logicalTopIsAuto = logicalTop.isAuto();
3663 bool logicalBottomIsAuto = logicalBottom.isAuto(); 3663 bool logicalBottomIsAuto = logicalBottom.isAuto();
3664 RenderView* renderView = view(); 3664 RenderView* renderView = view();
3665 3665
3666 // Height is never unsolved for tables. 3666 // Height is never unsolved for tables.
3667 if (isTable()) { 3667 if (isTable()) {
3668 logicalHeightLength.setValue(Fixed, contentLogicalHeight); 3668 if (style()->boxSizing() == BORDER_BOX)
3669 logicalHeightLength.setValue(Fixed, logicalHeight);
3670 else
3671 logicalHeightLength.setValue(Fixed, contentLogicalHeight);
3669 logicalHeightIsAuto = false; 3672 logicalHeightIsAuto = false;
3670 } 3673 }
3671 3674
3672 LayoutUnit resolvedLogicalHeight; 3675 LayoutUnit resolvedLogicalHeight;
3673 if (logicalHeightLength.isIntrinsic()) 3676 if (logicalHeightLength.isIntrinsic())
3674 resolvedLogicalHeight = computeIntrinsicLogicalContentHeightUsing(logica lHeightLength, contentLogicalHeight, bordersPlusPadding); 3677 resolvedLogicalHeight = computeIntrinsicLogicalContentHeightUsing(logica lHeightLength, contentLogicalHeight, bordersPlusPadding);
3675 else 3678 else
3676 resolvedLogicalHeight = adjustContentBoxLogicalHeightForBoxSizing(valueF orLength(logicalHeightLength, containerLogicalHeight, renderView)); 3679 resolvedLogicalHeight = adjustContentBoxLogicalHeightForBoxSizing(valueF orLength(logicalHeightLength, containerLogicalHeight, renderView));
3677 3680
3678 if (!logicalTopIsAuto && !logicalHeightIsAuto && !logicalBottomIsAuto) { 3681 if (!logicalTopIsAuto && !logicalHeightIsAuto && !logicalBottomIsAuto) {
(...skipping 1088 matching lines...) Expand 10 before | Expand all | Expand 10 after
4767 return 0; 4770 return 0;
4768 4771
4769 if (!layoutState && !flowThreadContainingBlock()) 4772 if (!layoutState && !flowThreadContainingBlock())
4770 return 0; 4773 return 0;
4771 4774
4772 RenderBlock* containerBlock = containingBlock(); 4775 RenderBlock* containerBlock = containingBlock();
4773 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop(); 4776 return containerBlock->offsetFromLogicalTopOfFirstPage() + logicalTop();
4774 } 4777 }
4775 4778
4776 } // namespace WebCore 4779 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698