Use AnalysisDriverUnlinkedUnit as a container for UnlinkedUnit and referenced names.

Use AnalysisDriverUnlinkedUnit as a container for UnlinkedUnit and referenced names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/1d54c1e9c04858b83da4ca8e5d8e9fb16018c817

[Paul Berry, 2016-11-21 13:51:26]

lgtm

[Brian Wilkerson, 2016-11-21 15:54:37]

lgtm

https://codereview.chromium.org/2520593003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2520593003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:274: _referencedNames = new
Set<String>.from(driverUnlinkedUnit.referencedNames);
This is kind of ugly. Consider adding a getter to AnalysisDriverUnlinkedUnit,
such as referencedNameSet, that would create the set.

[scheglov, 2016-11-21 17:04:54]

https://codereview.chromium.org/2520593003/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right):

https://codereview.chromium.org/2520593003/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/file_state.dart:274: _referencedNames = new
Set<String>.from(driverUnlinkedUnit.referencedNames);
On 2016/11/21 15:54:37, Brian Wilkerson wrote:
> This is kind of ugly. Consider adding a getter to AnalysisDriverUnlinkedUnit,
> such as referencedNameSet, that would create the set.

We use flat buffers just as data.
Any additional services should be on top of it, not inside of it.
And this is the place where we provide such additional service - quick lookup
for names.

[scheglov, 2016-11-21 17:07:08]

Description was changed from

==========
Use AnalysisDriverUnlinkedUnit as a container for UnlinkedUnit and referenced
names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Use AnalysisDriverUnlinkedUnit as a container for UnlinkedUnit and referenced
names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/1d54c1e9c04858b83da4ca8e5d8e9fb16018c817
==========

[scheglov, 2016-11-21 17:07:09]

Committed patchset #1 (id:1) manually as
1d54c1e9c04858b83da4ca8e5d8e9fb16018c817 (presubmit successful).