Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2655)

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_url_entry.js

Issue 2520573002: MD Settings: implement support for extension-controlled startup URLs (Closed)
Patch Set: fix closure? Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
diff --git a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
index e3e93dda2bb254b9479b25b0f104870554ddb27a..b5d363e47b21f1a153c1d241d602689d1ff14887 100644
--- a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
+++ b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
@@ -21,6 +21,11 @@ Polymer({
is: 'settings-startup-url-entry',
properties: {
+ editable: {
+ type: Boolean,
+ reflectToAttribute: true,
+ },
+
/** @type {!StartupPageInfo} */
model: Object,
},
@@ -50,7 +55,7 @@ Polymer({
/** @private */
onDotsTap_: function() {
var actionMenu = /** @type {!CrActionMenuElement} */(
- this.$.menu.get());
- actionMenu.showAt(assert(this.$.dots));
+ this.$$('#menu').get());
+ actionMenu.showAt(assert(this.$$('#dots')));
},
});

Powered by Google App Engine
This is Rietveld 408576698