MD Settings: implement support for extension-controlled startup URLs

chrome/test/data/webui/settings/startup_urls_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_startup_urls_page', function() {
   /**
    * @constructor
    * @implements {settings.StartupUrlsPageBrowserProxy}
    * @extends {settings.TestBrowserProxy}
    */
@@ skipping 178 matching lines @@
     /** @type {?SettingsStartupUrlsPageElement} */
     var page = null;
 
     var browserProxy = null;
 
     setup(function() {
       browserProxy = new TestStartupUrlsPageBrowserProxy();
       settings.StartupUrlsPageBrowserProxyImpl.instance_ = browserProxy;
       PolymerTest.clearBody();
       page = document.createElement('settings-startup-urls-page');
+      page.prefs = {
+        session: {
+          restore_on_startup: {
+            type: chrome.settingsPrivate.PrefType.NUMBER,
+            value: 5,
+          },
+        },
+      };
       document.body.appendChild(page);
+      Polymer.dom.flush();
     });
 
     teardown(function() { page.remove(); });
 
     // Test that the page is requesting information from the browser.
     test('Initialization', function() {
       return browserProxy.whenCalled('loadStartupPages');
     });
 
     test('UseCurrentPages', function() {
-      var useCurrentPagesButton = page.$.useCurrentPages;
+      var useCurrentPagesButton = page.$$('#useCurrentPages');
       assertTrue(!!useCurrentPagesButton);
       MockInteractions.tap(useCurrentPagesButton);
       return browserProxy.whenCalled('useCurrentPages');
     });
 
     test('AddPage_OpensDialog', function() {
-      var addPageButton = page.$.addPage;
+      var addPageButton = page.$$('#addPage');
       assertTrue(!!addPageButton);
       assertFalse(!!page.$$('settings-startup-url-dialog'));
 
       MockInteractions.tap(addPageButton);
       Polymer.dom.flush();
       assertTrue(!!page.$$('settings-startup-url-dialog'));
     });
 
     test('EditPage_OpensDialog', function() {
       assertFalse(!!page.$$('settings-startup-url-dialog'));
@@ skipping 20 matching lines @@
       cr.webUIListenerCallback('update-startup-pages', [entry1, entry2]);
       page.fire(settings.EDIT_STARTUP_URL_EVENT, entry2);
       Polymer.dom.flush();
 
       assertTrue(!!page.$$('settings-startup-url-dialog'));
       cr.webUIListenerCallback('update-startup-pages', [entry1]);
       Polymer.dom.flush();
 
       assertFalse(!!page.$$('settings-startup-url-dialog'));
     });
+
+    test('StarupPages_WhenExtensionControlled', function() {
+      assertFalse(!!page.get('prefs.session.startup_urls.controlledBy'));
+      assertFalse(!!page.$$('extension-controlled-indicator'));
+      assertTrue(!!page.$$('#addPage'));
+      assertTrue(!!page.$$('#useCurrentPages'));
+
+      page.set('prefs.session.startup_urls', {
+        controlledBy: chrome.settingsPrivate.ControlledBy.EXTENSION,
+        controlledByName: 'Totally Real Extension',
+        enforcement: chrome.settingsPrivate.Enforcement.ENFORCED,
+        extensionId: 'mefmhpjnkplhdhmfmblilkgpkbjebmij',
+        type: chrome.settingsPrivate.PrefType.NUMBER,
+        value: 5,
+      });
+      Polymer.dom.flush();
+
+      assertTrue(!!page.$$('extension-controlled-indicator'));
+      assertFalse(!!page.$$('#addPage'));
+      assertFalse(!!page.$$('#useCurrentPages'));
+    });
   });
 
   /** @return {!StartupPageInfo} */
   function createSampleUrlEntry() {
     return {
       modelIndex: 2,
       title: 'Test page',
       tooltip: 'test tooltip',
       url: 'chrome://foo',
     };
   }
 
   suite('StartupUrlEntry', function() {
     /** @type {?SettingsStartupUrlEntryElement} */
     var element = null;
 
     var browserProxy = null;
 
     setup(function() {
       browserProxy = new TestStartupUrlsPageBrowserProxy();
       settings.StartupUrlsPageBrowserProxyImpl.instance_ = browserProxy;
       PolymerTest.clearBody();
       element = document.createElement('settings-startup-url-entry');
       element.model = createSampleUrlEntry();
       document.body.appendChild(element);
-
-      // Bring up the popup menu for the following tests to use.
-      assertFalse(!!element.$$('dialog[is=cr-action-menu]'));
-      MockInteractions.tap(element.$.dots);
       Polymer.dom.flush();
-      assertTrue(!!element.$$('dialog[is=cr-action-menu]'));
     });
 
     teardown(function() { element.remove(); });
 
     test('MenuOptions_Remove', function() {
+      element.editable = true;

[dpapad, 2016/11/19 01:32:39]

Nit (optional): Perhaps do this in setup() so that by default setup() creates an
editable entry (as it was before this CL).

[Dan Beam, 2016/11/19 01:55:28]

eh, that results in more touching of the prod code (because otherwise the
'Editable' test fails, and I don't like using assertEquals(.style.display,
'none'))

[Dan Beam, 2016/11/19 01:55:49]

(if I don't add restamp to the dom-if in the prod code)

+      Polymer.dom.flush();
+
+      // Bring up the popup menu.
+      assertFalse(!!element.$$('dialog[is=cr-action-menu]'));
+      MockInteractions.tap(element.$$('#dots'));
+      Polymer.dom.flush();
+      assertTrue(!!element.$$('dialog[is=cr-action-menu]'));
+
       var removeButton = element.shadowRoot.querySelector('#remove')
       MockInteractions.tap(removeButton);
       return browserProxy.whenCalled('removeStartupPage').then(
           function(modelIndex) {
             assertEquals(element.model.modelIndex, modelIndex);
           });
     });
+
+    test('Editable', function() {
+      assertFalse(!!element.editable);
+      assertFalse(!!element.$$('#dots'));
+
+      element.editable = true;
+      Polymer.dom.flush();
+      assertTrue(!!element.$$('#dots'));
+    });
   });
 });