Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10324)

Unified Diff: core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp

Issue 2520493002: Make CPDF_Stream() take unique_ptr's to its dictionary. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/fpdfapi/page/cpdf_image.cpp » ('j') | core/fpdfapi/page/cpdf_image.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp
diff --git a/core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp b/core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp
index 837697273f3b6346132a106ba583e0d5afe3b1c8..3065e70ac96b5df9e97fdc0990b206a3e78f8df6 100644
--- a/core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp
+++ b/core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp
@@ -126,14 +126,14 @@ void CPDF_PageContentGenerator::ProcessForm(CFX_ByteTextBuf& buf,
CFX_FloatRect bbox = m_pPage->GetPageBBox();
matrix.TransformRect(bbox);
- CPDF_Dictionary* pFormDict =
- new CPDF_Dictionary(m_pDocument->GetByteStringPool());
+ auto pFormDict =
+ pdfium::MakeUnique<CPDF_Dictionary>(m_pDocument->GetByteStringPool());
pFormDict->SetNewFor<CPDF_Name>("Type", "XObject");
pFormDict->SetNewFor<CPDF_Name>("Subtype", "Form");
pFormDict->SetRectFor("BBox", bbox);
CPDF_Stream* pStream = m_pDocument->NewIndirect<CPDF_Stream>();
- pStream->InitStream(data, size, pFormDict);
+ pStream->InitStream(data, size, std::move(pFormDict));
CFX_ByteString name = RealizeResource(pStream->GetObjNum(), "XObject");
buf << "/" << PDF_NameEncode(name) << " Do Q\n";
« no previous file with comments | « no previous file | core/fpdfapi/page/cpdf_image.cpp » ('j') | core/fpdfapi/page/cpdf_image.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698