Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2520453002: Revert of Roll clang 284979:287226. (Closed)

Created:
4 years, 1 month ago by Nico
Modified:
4 years, 1 month ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll clang 284979:287226. (patchset #1 id:1 of https://codereview.chromium.org/2508323003/ ) Reason for revert: Makes every link on Mac warn clang: warning: libLTO.dylib relative to clang installed dir not found; using 'ld' default search path instead [-Wliblto] Probably due to https://reviews.llvm.org/D25932. We need to talk to Mehdi and come up with a plan. Also, it's lame that that warning isn't affected by -Werror, else the bots would've caught this. Original issue's description: > Roll clang 284979:287226. > > Ran `tools/clang/scripts/upload_revision.py 287226`. > > BUG=665063 > > Committed: https://crrev.com/9b87c91ac267d38736890d2b63e6e56a893ccbbb > Cr-Commit-Position: refs/heads/master@{#433124} TBR=hans@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=665063 Committed: https://crrev.com/ece50209a690cba3f3450d9d11296be844a94ca1 Cr-Commit-Position: refs/heads/master@{#433230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/clang/scripts/update.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
Created Revert of Roll clang 284979:287226.
4 years, 1 month ago (2016-11-18 17:39:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520453002/1
4 years, 1 month ago (2016-11-18 17:40:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 17:41:50 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ece50209a690cba3f3450d9d11296be844a94ca1 Cr-Commit-Position: refs/heads/master@{#433230}
4 years, 1 month ago (2016-11-18 17:45:30 UTC) #7
hans
lgtm, thanks How did you find this? Just happened to be building something?
4 years, 1 month ago (2016-11-18 17:48:06 UTC) #8
Nico
4 years, 1 month ago (2016-11-18 17:51:24 UTC) #9
Message was sent while issue was closed.
Someone else who happened to be building something pinged me this morning
and asked me if this is normal. It took me a bit to make the connection,
but then I tried building something with and without the roll and saw it
too.

On Fri, Nov 18, 2016 at 12:48 PM, <hans@chromium.org> wrote:

> lgtm, thanks
>
> How did you find this? Just happened to be building something?
>
> https://codereview.chromium.org/2520453002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698