Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2520423005:
[Telemetry] Disable system_health.memory_desktop on win10 (Closed)
Description[Telemetry] Disable system_health.memory_desktop on win10
It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations.
BUG=667941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/a3e6a48f576f8130788f731c8d8e6c7525118edf
Cr-Commit-Position: refs/heads/master@{#434132}
Patch Set 1 #
Messages
Total messages: 20 (12 generated)
Description was changed from ========== [Telemetry] Disable system_health.memory_desktop on win10 It crashes on Windows Zen Book, and Windows High DPI: Both win10 congigurations. BUG=667941 ========== to ========== [Telemetry] Disable system_health.memory_desktop on win10 It crashes on Windows Zen Book, and Windows High DPI: Both win10 congigurations. BUG=667941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by fmeawad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Telemetry] Disable system_health.memory_desktop on win10 It crashes on Windows Zen Book, and Windows High DPI: Both win10 congigurations. BUG=667941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Disable system_health.memory_desktop on win10 It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations. BUG=667941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
eakuefner@chromium.org changed reviewers: + eakuefner@chromium.org
lgtm
The CQ bit was unchecked by fmeawad@chromium.org
The CQ bit was checked by fmeawad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_...)
The CQ bit was checked by fmeawad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1479878343695330, "parent_rev":
"e53dcb6e9e930106426481a3b049b38db3d75e19", "commit_rev":
"a38857b83e88f5472b0d4858cae0a49e9ed1831f"}
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Disable system_health.memory_desktop on win10 It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations. BUG=667941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Disable system_health.memory_desktop on win10 It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations. BUG=667941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Disable system_health.memory_desktop on win10 It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations. BUG=667941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Disable system_health.memory_desktop on win10 It crashes on Windows Zen Book, and Windows High DPI: Both win10 configurations. BUG=667941 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/a3e6a48f576f8130788f731c8d8e6c7525118edf Cr-Commit-Position: refs/heads/master@{#434132} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a3e6a48f576f8130788f731c8d8e6c7525118edf Cr-Commit-Position: refs/heads/master@{#434132}
Message was sent while issue was closed.
On 2016/11/23 08:20:02, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as > https://crrev.com/a3e6a48f576f8130788f731c8d8e6c7525118edf > Cr-Commit-Position: refs/heads/master@{#434132} In general, for system health, we should only disable individual stories that fail. This case seems to be a mass failure, hence I am ok with this.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2522273002/ by nednguyen@google.com. The reason for reverting is: System health benchmark should be disabled at story level, not the whole benchmark level (if possible).. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
