Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2520403002: Add a configurable parse-depth limit when parsing JFV headers, and use it for Feature-Policy Header (Closed)

Created:
4 years, 1 month ago by iclelland
Modified:
4 years, 1 month ago
Reviewers:
pfeldman
CC:
chromium-reviews, blink-reviews, fuzzing_chromium.org, iclelland, lunalu1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a configurable parse-depth limit when parsing JFV headers, and use it for Feature-Policy Header The limit is deliberately set higher than the actual required depth for a valid policy, so that strings which are malformed but not malicious can still be passed through the Feature Policy header parser which can emit more meaningful error messages. BUG=662920 Committed: https://crrev.com/cb3e5ca8d303f10841d9985ff350d9fcbca49c9d Cr-Commit-Position: refs/heads/master@{#434123}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/json/JSONParserFuzzer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.h View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
iclelland
+r pfeldman, can you PTAL? Thanks! This follows https://codereview.chromium.org/2380823002/ by actually using the configurable depth ...
4 years, 1 month ago (2016-11-22 19:43:48 UTC) #5
iclelland
(Re-sending with a real reviewer set now :) ) +r pfeldman, can you PTAL? Thanks!
4 years, 1 month ago (2016-11-22 19:44:26 UTC) #7
pfeldman
lgtm
4 years, 1 month ago (2016-11-22 19:48:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520403002/20001
4 years, 1 month ago (2016-11-23 03:50:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-23 05:37:34 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-23 05:39:16 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb3e5ca8d303f10841d9985ff350d9fcbca49c9d
Cr-Commit-Position: refs/heads/master@{#434123}

Powered by Google App Engine
This is Rietveld 408576698