Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2520383002: Revert of Remove unused build override (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, kjellander_chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove unused build override (patchset #2 id:20001 of https://codereview.chromium.org/2498603002/ ) Reason for revert: This breaks all the Mac builds. /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen //out/Debug-iphonesimulator --check -> returned 1 ERROR at //build/config/mac/mac_sdk.gni:18:27: Undefined identifier mac_deployment_target = mac_deployment_target_build_override ^----------------------------------- See //build/toolchain/mac/BUILD.gn:14:1: whence it was imported. import("//build/config/mac/mac_sdk.gni") ^-------------------------------------- See //BUILD.gn:73:1: which caused the file to be included. group("gn_all") { ^---------------- GN gen failed: 1 Original issue's description: > Remove unused build override > > The only downstream project using this used to be WebRTC, where it's no > longer needed. > > BUG=webrtc:6431 > NOTRY=true > > Committed: https://crrev.com/6dd0024530bfa1d1f88840204633788bad70239e > Cr-Commit-Position: refs/heads/master@{#433856} TBR=dpranke@chromium.org,kjellander@chromium.org,kthelgason@webrtc.org,kthelgason@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6431 Committed: https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a Cr-Commit-Position: refs/heads/master@{#433861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build_overrides/build.gni View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Avi (use Gerrit)
Created Revert of Remove unused build override
4 years, 1 month ago (2016-11-22 15:14:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520383002/1
4 years, 1 month ago (2016-11-22 15:14:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 15:15:25 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5638488a75f3e1424bedc0607e2183b9d0ad8f4a Cr-Commit-Position: refs/heads/master@{#433861}
4 years, 1 month ago (2016-11-22 15:18:51 UTC) #8
kthelgason_chromium
4 years, 1 month ago (2016-11-22 15:23:56 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2525673002/ by kthelgason@chromium.org.

The reason for reverting is: Reland after fixing mac builds..

Powered by Google App Engine
This is Rietveld 408576698