Use /OPT:REF in clang optimized static builds

Use /OPT:REF in clang static release builds

Chromium normally builds with /PROFILE in static release builds, which
implies "/OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO". We can't use
/PROFILE with Clang, so instead pass the list of implied flags to make
Clang builds more closely match MSVC builds. We already do this for
is_win_fastlink=true builds, presumably for the same reason.

It turns out that the chrome_elf_unittests relies on /OPT:REF because it
allows the linker to remove unused user32.dll dependencies brought in by
//base. These tests only run in release+static builds, and most clang
release+static bots do official builds. Official builds already use
/OPT:REF for unrelated reasons, so we only see these test failures on
ASan bots, which don't do official builds.

BUG=646414
R=thakis@chromium.org

Committed: https://crrev.com/7bff5aca5d8144576a46b3dc0a37086c7e1a8d25
Cr-Commit-Position: refs/heads/master@{#433929}

[Reid Kleckner, 2016-11-22 17:25:43]

The CQ bit was checked by rnk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 17:26:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-22 17:53:28]

Change lgtm, but "and most Windows Clang ToT bots do official
builds" is not true: Only the static release bots do official builds. The debug
component and the release component bots do unofficial builds. (I don't think
that changes the analysis though.)

[commit-bot: I haz the power, 2016-11-22 18:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:19:47]

Dry run: This issue passed the CQ dry run.

[Reid Kleckner, 2016-11-22 18:34:58]

On 2016/11/22 17:53:28, Nico wrote:
> Change lgtm, but "and most Windows Clang ToT bots do official
> builds" is not true: Only the static release bots do official builds. The
debug
> component and the release component bots do unofficial builds. (I don't think
> that changes the analysis though.)

Right, the chrome_elf_unittests only run in static release builds.

[Reid Kleckner, 2016-11-22 18:49:42]

Description was changed from

==========
Use /OPT:REF in clang optimized static builds

Chromium normally builds with /PROFILE in optimized static builds, which
implies "/OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO". It turns out that
the chrome_elf_unittests relies on /OPT:REF because it allows the linker
to remove unused user32.dll dependencies brought in by //base.  Official
builds already use /OPT:REF, and most Windows Clang ToT bots do official
builds. The only ones that don't are the ASan bots, and this change
should fix those bots.

BUG=646414
R=pennymac@chromium.org,thakis@chromium.org
==========

to

==========
Use /OPT:REF in clang static release builds

Chromium normally builds with /PROFILE in static release builds, which
implies "/OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO". We can't use
/PROFILE with Clang, so instead pass the list of implied flags to make
Clang builds more closely match MSVC builds. We already do this for
is_win_fastlink=true builds, presumably for the same reason.

It turns out that the chrome_elf_unittests relies on /OPT:REF because it
allows the linker to remove unused user32.dll dependencies brought in by
//base. These tests only run in release+static builds, and most clang
release+static bots do official builds. Official builds already use
/OPT:REF for unrelated reasons, so we only see these test failures on
ASan bots, which don't do official builds.

BUG=646414
R=thakis@chromium.org
==========

[Reid Kleckner, 2016-11-22 18:49:46]

The CQ bit was checked by rnk@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:50:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 18:55:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479840586846490, "parent_rev":
"fd54f18640f812d46068bca11440e89e1e03d95f", "commit_rev":
"d0962d17242458e3e7db1d50757a1e64686707d5"}

[commit-bot: I haz the power, 2016-11-22 18:55:49]

Description was changed from

==========
Use /OPT:REF in clang static release builds

Chromium normally builds with /PROFILE in static release builds, which
implies "/OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO". We can't use
/PROFILE with Clang, so instead pass the list of implied flags to make
Clang builds more closely match MSVC builds. We already do this for
is_win_fastlink=true builds, presumably for the same reason.

It turns out that the chrome_elf_unittests relies on /OPT:REF because it
allows the linker to remove unused user32.dll dependencies brought in by
//base. These tests only run in release+static builds, and most clang
release+static bots do official builds. Official builds already use
/OPT:REF for unrelated reasons, so we only see these test failures on
ASan bots, which don't do official builds.

BUG=646414
R=thakis@chromium.org
==========

to

==========
Use /OPT:REF in clang static release builds

Chromium normally builds with /PROFILE in static release builds, which
implies "/OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO". We can't use
/PROFILE with Clang, so instead pass the list of implied flags to make
Clang builds more closely match MSVC builds. We already do this for
is_win_fastlink=true builds, presumably for the same reason.

It turns out that the chrome_elf_unittests relies on /OPT:REF because it
allows the linker to remove unused user32.dll dependencies brought in by
//base. These tests only run in release+static builds, and most clang
release+static bots do official builds. Official builds already use
/OPT:REF for unrelated reasons, so we only see these test failures on
ASan bots, which don't do official builds.

BUG=646414
R=thakis@chromium.org
==========

[commit-bot: I haz the power, 2016-11-22 18:55:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-22 18:57:48]

Description was changed from

==========
Use /OPT:REF in clang static release builds

Chromium normally builds with /PROFILE in static release builds, which
implies "/OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO". We can't use
/PROFILE with Clang, so instead pass the list of implied flags to make
Clang builds more closely match MSVC builds. We already do this for
is_win_fastlink=true builds, presumably for the same reason.

It turns out that the chrome_elf_unittests relies on /OPT:REF because it
allows the linker to remove unused user32.dll dependencies brought in by
//base. These tests only run in release+static builds, and most clang
release+static bots do official builds. Official builds already use
/OPT:REF for unrelated reasons, so we only see these test failures on
ASan bots, which don't do official builds.

BUG=646414
R=thakis@chromium.org
==========

to

==========
Use /OPT:REF in clang static release builds

Chromium normally builds with /PROFILE in static release builds, which
implies "/OPT:REF /OPT:ICF /INCREMENTAL:NO /FIXED:NO". We can't use
/PROFILE with Clang, so instead pass the list of implied flags to make
Clang builds more closely match MSVC builds. We already do this for
is_win_fastlink=true builds, presumably for the same reason.

It turns out that the chrome_elf_unittests relies on /OPT:REF because it
allows the linker to remove unused user32.dll dependencies brought in by
//base. These tests only run in release+static builds, and most clang
release+static bots do official builds. Official builds already use
/OPT:REF for unrelated reasons, so we only see these test failures on
ASan bots, which don't do official builds.

BUG=646414
R=thakis@chromium.org

Committed: https://crrev.com/7bff5aca5d8144576a46b3dc0a37086c7e1a8d25
Cr-Commit-Position: refs/heads/master@{#433929}
==========

[commit-bot: I haz the power, 2016-11-22 18:57:49]

Patchset 1 (id:??) landed as
https://crrev.com/7bff5aca5d8144576a46b3dc0a37086c7e1a8d25
Cr-Commit-Position: refs/heads/master@{#433929}