Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issue 2520373002: Remove the old image fetcher (Closed)

Created:
4 years, 1 month ago by gambard
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, cbentzel+watch_chromium.org, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the old image fetcher This CL removes the old image fetcher as it has been moved to ImageDataFetcher. BUG=667747 Committed: https://crrev.com/d4c792d25642914be34365507e93e0f4378b2eb9 Cr-Commit-Position: refs/heads/master@{#436271}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove the files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -327 lines) Patch
M ios/chrome/browser/native_app_launcher/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/net/BUILD.gn View 1 2 3 chunks +0 lines, -15 lines 0 comments Download
D ios/chrome/browser/net/image_fetcher.h View 1 2 1 chunk +0 lines, -90 lines 0 comments Download
D ios/chrome/browser/net/image_fetcher.mm View 1 2 1 chunk +0 lines, -177 lines 0 comments Download
D ios/chrome/browser/net/mock_image_fetcher.h View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D ios/chrome/browser/net/mock_image_fetcher.mm View 1 2 1 chunk +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
gambard
PTAL.
4 years, 1 month ago (2016-11-22 14:42:36 UTC) #2
sdefresne
lgtm
4 years, 1 month ago (2016-11-22 14:47:12 UTC) #3
gambard
Removing the files as they now moved.
4 years ago (2016-12-02 09:21:19 UTC) #4
sdefresne
Can you update the description as it is no longer describing what this CL does? ...
4 years ago (2016-12-05 11:06:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520373002/40001
4 years ago (2016-12-05 11:51:50 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-05 12:57:13 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 12:59:24 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d4c792d25642914be34365507e93e0f4378b2eb9
Cr-Commit-Position: refs/heads/master@{#436271}

Powered by Google App Engine
This is Rietveld 408576698