tools/perf/PRESUBMIT.py - Issue 2520353003: Remove android_s5_perf_cq from tools/perf presubmits

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/PRESUBMIT.py

Issue 2520353003: Remove android_s5_perf_cq from tools/perf presubmits (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2012 The Chromium Authors. All rights reserved.	1 # Copyright 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """Presubmit script for changes affecting tools/perf/.	5 """Presubmit script for changes affecting tools/perf/.

6	6

7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts	7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts

8 for more details about the presubmit API built into depot_tools.	8 for more details about the presubmit API built into depot_tools.

9 """	9 """

10	10

(...skipping 110 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
121 benchmarks_modified = _AreBenchmarksModified(change)	121 benchmarks_modified = _AreBenchmarksModified(change)

122 rietveld_obj = cl.RpcServer()	122 rietveld_obj = cl.RpcServer()

123 issue = cl.issue	123 issue = cl.issue

124 original_description = rietveld_obj.get_description(issue)	124 original_description = rietveld_obj.get_description(issue)

125 if not benchmarks_modified or re.search(	125 if not benchmarks_modified or re.search(

126 r'^CQ_INCLUDE_TRYBOTS=.*', original_description, re.M \| re.I):	126 r'^CQ_INCLUDE_TRYBOTS=.*', original_description, re.M \| re.I):

127 return []	127 return []

128	128

129 results = []	129 results = []

130 bots = [	130 bots = [

131 'android_s5_perf_cq',

132 'linux_perf_cq',	131 'linux_perf_cq',

133 'mac_retina_perf_cq',	132 'mac_retina_perf_cq',

134 'winx64_10_perf_cq'	133 'winx64_10_perf_cq'

135 ]	134 ]

136 bots = ['master.tryserver.chromium.perf:%s' % s for s in bots]	135 bots = ['master.tryserver.chromium.perf:%s' % s for s in bots]

137 bots_string = ';'.join(bots)	136 bots_string = ';'.join(bots)

138 description = original_description	137 description = original_description

139 description += '\nCQ_INCLUDE_TRYBOTS=%s' % bots_string	138 description += '\nCQ_INCLUDE_TRYBOTS=%s' % bots_string

140 results.append(output_api.PresubmitNotifyResult(	139 results.append(output_api.PresubmitNotifyResult(

141 'Automatically added Perf trybots to run Telemetry benchmarks on CQ.'))	140 'Automatically added Perf trybots to run Telemetry benchmarks on CQ.'))

142	141

143 if description != original_description:	142 if description != original_description:

144 rietveld_obj.update_description(issue, description)	143 rietveld_obj.update_description(issue, description)

145	144

146 return results	145 return results

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »